Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 wallet ProfileAssetsList #5097

Merged
merged 4 commits into from
Feb 23, 2023
Merged

🔧 wallet ProfileAssetsList #5097

merged 4 commits into from
Feb 23, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 22, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

before
Screenshot 2023-02-22 at 15-19-30 KodaDot - NFT Market Explorer

after
Screenshot 2023-02-22 at 15-16-34 KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner February 22, 2023 14:19
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team February 22, 2023 14:19
@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 32fcf3f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f78b5072f4a70008065188
😎 Deploy Preview https://deploy-preview-5097--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Feb 22, 2023

now you're not rich anymore 🙄

@exezbcz
Copy link
Member

exezbcz commented Feb 22, 2023

can the usd amounts also be aligned to right? so the total count is in line with the amounts above? :D

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 22, 2023

can the usd amounts also be aligned to right? so the total count is in line with the amounts above? :D

I would suggest to align every numbers in this table to the right, wdyt?

@exezbcz
Copy link
Member

exezbcz commented Feb 22, 2023

@roiLeo
yes
image

vikiival
vikiival approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some magic. YOLO

@codeclimate
Copy link

codeclimate bot commented Feb 23, 2023

Code Climate has analyzed commit 32fcf3f and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit aeb1427 into kodadot:main Feb 23, 2023
@roiLeo roiLeo deleted the fix/wallet/ProfileAssetsList branch February 23, 2023 16:07
@vikiival vikiival mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong equivalent in BSX-USD
5 participants
@roiLeo @yangwao @exezbcz @preschian @vikiival