Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero buttons #5101

Merged
merged 10 commits into from
Feb 25, 2023
Merged

Hero buttons #5101

merged 10 commits into from
Feb 25, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Feb 23, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image
image
image
image

@daiagi daiagi requested a review from a team as a code owner February 23, 2023 07:48
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team February 23, 2023 07:48
@kodabot
Copy link
Collaborator

kodabot commented Feb 23, 2023

WARNING @daiagi PR for issue #5072 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5072

@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 741d5f5
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f7a3eae1ad870008c2f0d0
😎 Deploy Preview https://deploy-preview-5101--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi
Copy link
Contributor Author

daiagi commented Feb 23, 2023

continue discussion from issue #5072

the first set of icons, on the left, are collection specific - the user input the links when creating and when customizing the collection page (tbd design from me)

did not see this sort of data when query for CollectionEntity, where might i find it? is it not yet implemented? @roiLeo
@exezbcz should the buttons be disabled if the user did not provide these links?

share button works similarly to gallery item, that means that once you click, it opens dropdown with share options - copy link or share on twitter

@exezbcz I'm not sure how the dropdown is designed, for now I've copied the design from gallery item

more button also opens a dropdown with options depending whether you are the owner or visitor
in case of visitor, there is simple option to report
on the other hand, owner can manage his collection through this, so options like customize, delete etc are there, this is also going to be specified once I come up with customization modal or something like that

here also i'm not sure how it is designed and are these functions/pages implemented, for now i've just put simple placeholders in the dropdown

@daiagi
Copy link
Contributor Author

daiagi commented Feb 23, 2023

tested on /bsx/collection/3030053998?page=1&redesign=true

@exezbcz
Copy link
Member

exezbcz commented Feb 23, 2023

@daiagi hey hey
If the owner does not fill it, the buttons will not be there.

  • i think we dont have the data yet, correct me if yes :D

drop down same as gallery
image
share as well
image

owner x user

  • yes, It will be later customized to the needs, The first step is to show the buttons there

@daiagi
Copy link
Contributor Author

daiagi commented Feb 23, 2023

thanks @exezbcz

drop down same as gallery

mind pointing me to the mentioned gallery page?
all I'm finding is the old design

nvm, found it on figma.

@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

did not see this sort of data when query for CollectionEntity, where might i find it? is it not yet implemented? @roiLeo @exezbcz should the buttons be disabled if the user did not provide these links?

Maybe use user identity data, hide btn when link doesn't exist

here also i'm not sure how it is designed and are these functions/pages implemented, for now i've just put simple placeholders in the dropdown

Not ready yet ref #4983, IMO we should hide it for now (disabled is an option)

@daiagi
Copy link
Contributor Author

daiagi commented Feb 23, 2023

Maybe use user identity data, hide btn when link doesn't exist

user identity data?! aren't these links collection specific?

@daiagi daiagi marked this pull request as draft February 23, 2023 08:16
@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

user identity data?! aren't these links collection specific?

Nope. It's not possible (yet) to set "links" attached to collectionEntity.

@daiagi daiagi marked this pull request as ready for review February 23, 2023 11:09
components/collection/HeroButtons.vue Outdated Show resolved Hide resolved
components/collection/HeroButtons.vue Outdated Show resolved Hide resolved
components/collection/HeroButtons.vue Outdated Show resolved Hide resolved
layouts/explore-layout.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Feb 23, 2023

Code Climate has analyzed commit 741d5f5 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Feb 24, 2023
@daiagi daiagi merged commit b4c626a into kodadot:main Feb 25, 2023
@vikiival vikiival mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero Buttons component
6 participants