Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign breadcrumbs #5105

Merged
merged 8 commits into from
Feb 26, 2023
Merged

Redesign breadcrumbs #5105

merged 8 commits into from
Feb 26, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Feb 23, 2023 •
edited by yangwao

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image
image

Hover

image
image

Hover over X

image
image

integrate with search

image

@daiagi daiagi requested a review from a team as a code owner February 23, 2023 14:05
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team February 23, 2023 14:05
@kodabot
Copy link
Collaborator

kodabot commented Feb 23, 2023

WARNING @daiagi PR for issue #4533 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4533

@netlify
Copy link

netlify bot commented Feb 23, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit a924e86
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f97dc2bb872800083dc1d8
😎 Deploy Preview https://deploy-preview-5105--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi daiagi marked this pull request as draft February 23, 2023 14:05
@exezbcz
Copy link
Member

exezbcz commented Feb 23, 2023 •
edited

image

the hover effect should be all over the breadcrumbs

By default there will be Buy Now, it's test and incentivize artist to always have something on sale

@daiagi daiagi marked this pull request as ready for review February 24, 2023 06:54
roiLeo
roiLeo approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

I would keep "Status" collapse open if we make "BUY NOW" option default
Screenshot 2023-02-24 at 08-26-13 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 24, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Feb 24, 2023

✅ wfm

I would keep "Status" collapse open if we make "BUY NOW" option default
Screenshot 2023-02-24 at 08-26-13 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

I agree, it would be clearer that a filter is active and where to change it
@exezbcz what do you think?

@exezbcz
Copy link
Member

exezbcz commented Feb 24, 2023

✅ wfm

I would keep "Status" collapse open if we make "BUY NOW" option default
Screenshot 2023-02-24 at 08-26-13 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

I agree, it would be clearer that a filter is active and where to change it
@exezbcz what do you think?

Yes, and we can also switch the order so status is on top

@daiagi
Copy link
Contributor Author

daiagi commented Feb 24, 2023

I would keep "Status" collapse open if we make "BUY NOW" option default
Yes, and we can also switch the order so status is on top

Done

this PR closes #5084 as well

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Feb 24, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 25, 2023

Code Climate has analyzed commit a924e86 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 50 usd

@vikiival vikiival merged commit 2422839 into kodadot:main Feb 26, 2023
@yangwao
Copy link
Member

yangwao commented Feb 26, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 38.88 USD/KSM ~ 1.286 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x1774886e389a620beddcf42df82420ec392c5f485d10d99c6949d13c1e6354df

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 26, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Feb 27, 2023 •
edited

@yangwao @vikiival hey
Payment didn't come through (insufficient funds)
https://kusama.subscan.io/extrinsic/16804335-2

@yangwao yangwao mentioned this pull request Mar 1, 2023
Closed
@yangwao yangwao removed the paid pull-request has been paid label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 50 usd

2 similar comments
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.01 USD/DOT ~ 9.98 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xe48eeadc55490b186ac4dc1376a612f47907580c16cd71ce7b6ab4eea3a516dd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate search term into breadcrumbs Redesign Explorer Filter Breadcumbs
6 participants
@daiagi @kodabot @exezbcz @vikiival @yangwao @roiLeo