Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not showing collection on cards #5114

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Feb 24, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 24, 2023 17:15
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team February 24, 2023 17:15
@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7e7965e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f980615515150008c52cf3
😎 Deploy Preview https://deploy-preview-5114--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Feb 24, 2023

SUCCESS @Jarsen136 PR for issue #5112 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@exezbcz
Copy link
Member

exezbcz commented Feb 24, 2023

good!
the weird rectangle is still there tho
image

@codeclimate
Copy link

codeclimate bot commented Feb 25, 2023

Code Climate has analyzed commit 7e7965e and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

good! the weird rectangle is still there tho image

Oh I got it. Fixed
image

@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Feb 26, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 39 USD/KSM ~ 0.513 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xe5385674832e9eb3708b0d60314f590bf88f07c660cd13ca489c86b226808a39

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 26, 2023
@vikiival vikiival merged commit 9bc7480 into kodadot:main Feb 26, 2023
@yangwao yangwao removed the paid pull-request has been paid label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5 USD/DOT ~ 4 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x12d871bea3c841e26729114f4e88d54fa65bf003c2c52bff904ead54d728f139

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not showing collection on cards
6 participants