Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection breadcrumbs #5127

Merged
merged 10 commits into from
Feb 28, 2023
Merged

Collection breadcrumbs #5127

merged 10 commits into from
Feb 28, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Feb 27, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@daiagi daiagi requested a review from a team as a code owner February 27, 2023 12:37
@daiagi daiagi requested review from preschian and roiLeo and removed request for a team February 27, 2023 12:37
@kodabot
Copy link
Collaborator

kodabot commented Feb 27, 2023

WARNING @daiagi PR for issue #5075 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5075

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dfbc5fb
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63fdb8721764dc0008b45a2e
😎 Deploy Preview https://deploy-preview-5127--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roiLeo
roiLeo reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff

components/items/ItemsGrid/ItemsGrid.vue Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGrid.vue Outdated Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
vikiival
vikiival requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree w @roiLeo

roiLeo
roiLeo reviewed Feb 28, 2023
View reviewed changes
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Feb 28, 2023

Code Climate has analyzed commit dfbc5fb and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 28, 2023
@vikiival vikiival merged commit 2402e06 into kodadot:main Feb 28, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 37.27 USD/KSM ~ 0.805 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0xe6253c5f3789986e331ea960498f4873f1425c2af343889e91a84fab02780b73

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 1, 2023
@vikiival vikiival mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection Breadcrumbs
5 participants
@daiagi @kodabot @yangwao @roiLeo @vikiival