Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: i18n $t return string type #5129

Merged
merged 1 commit into from
Feb 27, 2023
Merged

types: i18n $t return string type #5129

merged 1 commit into from
Feb 27, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Feb 27, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Refactoring

Context

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 27, 2023 15:46
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team February 27, 2023 15:46
@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 712acdc
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63fcd065e2bfcf0008082dea
😎 Deploy Preview https://deploy-preview-5129--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2023

Code Climate has analyzed commit 712acdc and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 27, 2023
@vikiival vikiival merged commit bef188f into main Feb 27, 2023
@vikiival vikiival deleted the fix-types-error-with-translation branch February 27, 2023 16:56
@preschian preschian mentioned this pull request Mar 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jarsen136 @roiLeo @vikiival