Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic grid on new collection #5135

Merged
merged 6 commits into from
Mar 1, 2023
Merged

feat: dynamic grid on new collection #5135

merged 6 commits into from
Mar 1, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 28, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen.Recording.2023-02-28.at.17.06.43.mov

@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 93c549b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ff0c145a8a530008aab565
😎 Deploy Preview https://deploy-preview-5135--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review February 28, 2023 10:08
@preschian preschian requested a review from a team as a code owner February 28, 2023 10:08
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team February 28, 2023 10:08
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to add the size of the layout in query since this is user preference.
store the grid changes in vuex preferences for now

components/shared/DynamicGrid.vue Outdated Show resolved Hide resolved
@preschian
Copy link
Member Author

I would prefer not to add the size of the layout in query since this is user preference. store the grid changes in vuex preferences for now

updated, now under vuex preferences

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!
✅ wfm

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Feb 28, 2023
@preschian
Copy link
Member Author

on this PR apply a dynamic grid on the new collection page
demo: https://deploy-preview-5135--koda-nuxt.netlify.app/bsx/collection/2551182625?redesign=true

cc @exezbcz @yangwao

@exezbcz
Copy link
Member

exezbcz commented Mar 1, 2023

@preschian And it is also applied to explore as shown in the screen record? Or does this apply only to collection? So far its looking good!

edit: Oki, it makes sense now :D didnt see the another issue

@roiLeo roiLeo enabled auto-merge March 1, 2023 08:26
@roiLeo
Copy link
Contributor

roiLeo commented Mar 1, 2023

🚀

@codeclimate
Copy link

codeclimate bot commented Mar 1, 2023

Code Climate has analyzed commit 93c549b and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit e8d7579 into main Mar 1, 2023
@roiLeo roiLeo deleted the feat/dynamic-grid branch March 1, 2023 08:33
@vikiival vikiival mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants