Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Explore gallery cards have unequeal height #5136

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix: Explore gallery cards have unequeal height #5136

merged 2 commits into from
Mar 1, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 28, 2023 15:02
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team February 28, 2023 15:02
@kodabot
Copy link
Collaborator

kodabot commented Feb 28, 2023

SUCCESS @Jarsen136 PR for issue #5077 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 28, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 751762f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ff4da185972c0007ad71dc
😎 Deploy Preview https://deploy-preview-5136--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 @roiLeo
Update libs/ui/src/components/NeoNftCard/NeoNftCard.vue
751762f 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@codeclimate
Copy link

codeclimate bot commented Mar 1, 2023

Code Climate has analyzed commit 751762f and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from roiLeo March 1, 2023 13:22
roiLeo
roiLeo approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Mar 1, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 37.76 USD/KSM ~ 0.53 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xe6e2496e78c55799f523f0efd9cd36b40cf39d805e857a100ea3fbad8535d58f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 1, 2023
@yangwao yangwao merged commit 7a2da03 into kodadot:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore gallery cards have unequeal height
5 participants
@Jarsen136 @kodabot @yangwao @preschian @roiLeo