Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faq not working #5141

Merged
merged 3 commits into from
Mar 1, 2023
Merged

fix: faq not working #5141

merged 3 commits into from
Mar 1, 2023

Conversation

Gavin-Gong
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Gavin-Gong Gavin-Gong requested a review from a team as a code owner March 1, 2023 12:21
@Gavin-Gong Gavin-Gong requested review from preschian and Jarsen136 and removed request for a team March 1, 2023 12:21
@kodabot
Copy link
Collaborator

kodabot commented Mar 1, 2023

SUCCESS @Gavin-Gong PR for issue #5140 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 131acce
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ff4f1e85972c0007ad9abd
😎 Deploy Preview https://deploy-preview-5141--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or instead add

{
  path: '~/components/common',
  extensions: ['vue'],
},

in nuxt.config.js

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the faq page path from /rmrk/faq to /faq

@roiLeo
Copy link
Contributor

roiLeo commented Mar 1, 2023

Let's change the faq page path from /rmrk/faq to /faq

not yet this page is only related with rmrk chain for now, later ref #4553

@Jarsen136 Jarsen136 self-requested a review March 1, 2023 12:45
components/TheFooter.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Mar 1, 2023

Code Climate has analyzed commit 131acce and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Mar 1, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

pay 20 usd

@yangwao yangwao merged commit a24442d into kodadot:main Mar 1, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 37.7 USD/KSM ~ 0.531 $KSM
🧗 GqheyaQ3c8SFBJYorTXyLW6jvLXKNAXzbad77NXoLYJBXXs
🔗 0xece9e903f0b2250f395a71d42dc53665cbb531d6f107fc7b700805e5ee1aea8e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ not working
6 participants