Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create Waifu leads to normal collection on mobile #5147

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 2, 2023 05:32
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team March 2, 2023 05:32
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit ab9facf
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640034e067a5860008cac9ed
😎 Deploy Preview https://deploy-preview-5147--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 2, 2023

SUCCESS @Jarsen136 PR for issue #5145 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Mar 2, 2023

Code Climate has analyzed commit ab9facf and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 222e154 into kodadot:main Mar 2, 2023
@yangwao
Copy link
Member

yangwao commented Mar 2, 2023

Seems doesn't work on Nova still, maybe need empty cache 🤔

@roiLeo
Copy link
Contributor

roiLeo commented Mar 2, 2023

Wfm

Screenshot_20230302-085259.png

@Jarsen136 Jarsen136 deleted the issue-5145 branch March 2, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Waifu leads to normal collection on mobile
5 participants