Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sorting in my profile not working properly #5169

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: Sorting in my profile not working properly #5169

merged 1 commit into from
Mar 6, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Mar 4, 2023 •
edited

Sorting in my profile not working properly

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136
fix:
c8c568b 
Sorting in my profile not working properly
@Jarsen136 Jarsen136 requested a review from a team as a code owner March 4, 2023 14:43
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team March 4, 2023 14:43
@kodabot
Copy link
Collaborator

kodabot commented Mar 4, 2023

SUCCESS @Jarsen136 PR for issue #5161 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 4, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c8c568b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640358ff174d30000845b340
😎 Deploy Preview https://deploy-preview-5169--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 4, 2023

Code Climate has analyzed commit c8c568b and detected 0 issues on this pull request.

View more on Code Climate.

vikiival
vikiival approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like YOLO

daiagi
daiagi approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 6, 2023
@vikiival vikiival merged commit 05f8d70 into kodadot:main Mar 6, 2023
@vikiival vikiival mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting in my profile not working properly
4 participants
@Jarsen136 @kodabot @vikiival @daiagi