Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search from collection page broken #5194

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 7, 2023 12:35
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team March 7, 2023 12:35
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit a7a222c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64073ae12030fe0008107c40
😎 Deploy Preview https://deploy-preview-5194--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 7, 2023

SUCCESS @Jarsen136 PR for issue #5193 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@daiagi
Copy link
Contributor

daiagi commented Mar 7, 2023

oh wow. talk about fast ⚡

@daiagi daiagi added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved labels Mar 7, 2023
@roiLeo roiLeo enabled auto-merge March 7, 2023 13:23
@codeclimate
Copy link

codeclimate bot commented Mar 7, 2023

Code Climate has analyzed commit a7a222c and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 1d2519e into kodadot:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search from collection page broken
5 participants