Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ remove unused explorer store #5207

Merged
merged 2 commits into from
Mar 9, 2023
Merged

✨ remove unused explorer store #5207

merged 2 commits into from
Mar 9, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Mar 8, 2023

PR Type

  • Refactoring

Context

@roiLeo roiLeo requested a review from a team as a code owner March 8, 2023 16:21
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team March 8, 2023 16:21
@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f272b21
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6408b5f605c4480008b73351
😎 Deploy Preview https://deploy-preview-5207--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 8, 2023

Code Climate has analyzed commit f272b21 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request Mar 8, 2023
Closed
vikiival
vikiival approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store.ts

Created by @roiLeo in ded77ea
Deprecated by @roiLeo in this PR

@vikiival vikiival merged commit 2f779f9 into kodadot:main Mar 9, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Mar 9, 2023

store.ts

Created by @roiLeo in ded77ea Deprecated by @roiLeo in this PR

Lol wait what?
Oh that was part of a big refactoring I didn't knew it's purposes, now it's not used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roiLeo @vikiival @Jarsen136