Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5155 adding margin when scrolling to desktop only #5211

Merged
merged 5 commits into from
Mar 13, 2023
Merged

#5155 adding margin when scrolling to desktop only #5211

merged 5 commits into from
Mar 13, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 9, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2023-03-08 at 7 50 06 PM

@prachi00 prachi00 requested a review from a team as a code owner March 9, 2023 03:50
@prachi00 prachi00 requested review from daiagi and Jarsen136 and removed request for a team March 9, 2023 03:50
@kodabot
Copy link
Collaborator

kodabot commented Mar 9, 2023

SUCCESS @prachi00 PR for issue #5155 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8b613e7
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640f130b8d8bb7000801173d
😎 Deploy Preview https://deploy-preview-5211--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 requested a review from exezbcz March 9, 2023 05:51
roiLeo
roiLeo suggested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would increase .sticky top value instead

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 9, 2023
@prachi00
Copy link
Member Author

I would increase .sticky top value instead

@roiLeo tried doing that, did not work as expected

@roiLeo
Copy link
Contributor

roiLeo commented Mar 10, 2023

nft-gallery/components/explore/SidebarFilter.vue

Lines 28 to 33 in c9072d6

.sticky {
position: -webkit-sticky;
position: sticky;
top: 72px;
height: calc(100vh - 72px);
}

maybe if we change the two 72px value it should do the work

@exezbcz
Copy link
Member

exezbcz commented Mar 10, 2023

that is still too much no? You are scrolling like 4 px over, It should scroll only over the stroke and stop

@prachi00 prachi00 requested a review from roiLeo March 11, 2023 23:14
roiLeo
roiLeo approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

daiagi
daiagi approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@daiagi daiagi added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Mar 12, 2023
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 12, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 30.07 USD/KSM ~ 0.333 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x250ad5b23edd9d1a7b87c85e1acd02121241e96e7ac1fb376ba2cc2913727065

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 12, 2023
@prachi00
Copy link
Member Author

@vikiival we can close this one

@roiLeo roiLeo enabled auto-merge March 13, 2023 12:11
@codeclimate
Copy link

codeclimate bot commented Mar 13, 2023

Code Climate has analyzed commit 8b613e7 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 6832734 into main Mar 13, 2023
@roiLeo roiLeo deleted the feat-margin-sidebar branch March 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

@exezbcz exezbcz Awaiting requested review from exezbcz

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar stick to navbar placement
7 participants
@prachi00 @kodabot @roiLeo @exezbcz @vikiival @yangwao @daiagi