Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ migrate preferences store to pinia #5219

Merged
merged 5 commits into from
Mar 13, 2023
Merged

✨ migrate preferences store to pinia #5219

merged 5 commits into from
Mar 13, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Mar 9, 2023 •
edited

PR Type

  • Refactoring

Context

@roiLeo roiLeo requested a review from a team as a code owner March 9, 2023 13:59
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team March 9, 2023 13:59
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 61e2c37
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640e89b639a82f0008e0ac05
😎 Deploy Preview https://deploy-preview-5219--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo mentioned this pull request Mar 9, 2023
Closed
@roiLeo roiLeo mentioned this pull request Mar 11, 2023
Merged
17 tasks
vikiival
vikiival approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM i just dont like the two sS next to each other

@daiagi daiagi enabled auto-merge March 12, 2023 11:39
@codeclimate
Copy link

codeclimate bot commented Mar 13, 2023

Code Climate has analyzed commit 61e2c37 and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi daiagi merged commit 506a650 into kodadot:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roiLeo @vikiival @daiagi