Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pressed enter two times to search on landing page #5221

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix: pressed enter two times to search on landing page #5221

merged 1 commit into from
Mar 10, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 9, 2023 16:17
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team March 9, 2023 16:17
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1da249c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640a0688cd13ea0008c5394c
😎 Deploy Preview https://deploy-preview-5221--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 9, 2023

SUCCESS @Jarsen136 PR for issue #5213 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Mar 9, 2023

Code Climate has analyzed commit 1da249c and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from roiLeo March 9, 2023 16:26
roiLeo
roiLeo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ works for me!

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 9, 2023
@roiLeo roiLeo merged commit e9ff859 into kodadot:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pressed enter two times to search on landing page
4 participants
@Jarsen136 @kodabot @roiLeo @daiagi