bug fix in explore sort

[daiagi]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes it is possible to select contradicting options in explore sort #5222
• Requires deployment <>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </bsx/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

SUCCESS @daiagi PR for issue #5222 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	60568d2
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/640f247191f6b700081103c8
😎 Deploy Preview	https://deploy-preview-5223--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[preschian]

why was this section removed anyway?

nft-gallery/components/explore/ExploreSort.vue

Lines 68 to 86 in 6d8b9fc

	function selectiveSort(options: string[]) {
	const uniqueOptions = {}
	if (!Array.isArray(options)) {
	return []
	}
	options.forEach((option) => {
	const opt = option.split('_')
	const identifier = opt[0]
	const sort = opt[1]
	uniqueOptions[identifier] = sort
	})
	return Object.keys(uniqueOptions).map((identifier) => {
	return `${identifier}_${uniqueOptions[identifier]}`
	})
	}

update: I miss this section when reviewing #5158
just revert that section should be fixed right?

[daiagi]

why was this section removed anyway?

nft-gallery/components/explore/ExploreSort.vue

Lines 68 to 86 in 6d8b9fc

	function selectiveSort(options: string[]) {
	const uniqueOptions = {}
	if (!Array.isArray(options)) {
	return []
	}
	options.forEach((option) => {
	const opt = option.split('_')
	const identifier = opt[0]
	const sort = opt[1]
	uniqueOptions[identifier] = sort
	})
	return Object.keys(uniqueOptions).map((identifier) => {
	return `${identifier}_${uniqueOptions[identifier]}`
	})
	}

update: I miss this section when reviewing #5158 just revert that section should be fixed right?

I removed it and i shouldn't have
I just rewrote the same functionality in different code style

if you prefer, i can restore it to how it was

[preschian]

if you prefer, i can restore it to how it was

I'm not a fan of the reduce function, for me, it's harder to read. but if the other ok with that, sure we can continue with it 👍

[vikiival]

Agree with @preschian, the code is really hard to read.

[vikiival]

.

[daiagi]

OK. I'll restore it to how it was before

[codeclimate]

Code Climate has analyzed commit 6dce48f and detected 0 issues on this pull request.

View more on Code Climate.

[Jarsen136]

wfm

[vikiival]

pay 25 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $25 @ 31.96 USD/KSM ~ 0.782 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x4c44bb5d9b53fb19b92ce99503e720c3b65a1e3bf58412ab64fedbe5e52ed75e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues