Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5209 activity tab #5224

Merged
merged 9 commits into from
Mar 15, 2023
Merged

#5209 activity tab #5224

merged 9 commits into from
Mar 15, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 10, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2023-03-09 at 7 49 30 PM

@prachi00 prachi00 requested a review from a team as a code owner March 10, 2023 04:05
@prachi00 prachi00 requested review from daiagi and Jarsen136 and removed request for a team March 10, 2023 04:05
@kodabot
Copy link
Collaborator

kodabot commented Mar 10, 2023

SUCCESS @prachi00 PR for issue #5209 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit ed45608
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6411c6b09e9c370008b09070
😎 Deploy Preview https://deploy-preview-5224--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

overall wfm

@exezbcz
Copy link
Member

exezbcz commented Mar 10, 2023

the button does not work on the full width and height - please make the select are the whole button.

image

if the name is too long we can I think cut it so its not jumping to the second row (somewhere on the edge with the second name - like on opensea for example
image )

  • that is the ideal situation that no content is jumping to second row

can we also increase the vertical padding? something like 20 is good - between the buttons and the stroke.
image

@prachi00
Copy link
Member Author

Left:

  • if the name is too long we can I think cut it so its not jumping to the second row (somewhere on the edge with the second name

can this be done in another issue? bit tricky to change the class in oruga table as this is deeply nested and would be through unscoped css

@prachi00 prachi00 requested a review from daiagi March 12, 2023 00:12
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use button or a tag for better accessibility

  • @click event on div?
  • is-clickable on label?

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 13, 2023
@prachi00
Copy link
Member Author

fixed for div, for label , it seems is-clickable is mandatory as even if we wrap it in a , the label tag inside it still wont show pointer without is-clickable

@exezbcz
Copy link
Member

exezbcz commented Mar 14, 2023

good! works for me

  • maybe last thing to change the vertical padding to 20 instead of 16px

image

thank you

@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Mar 15, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 15, 2023

Code Climate has analyzed commit ed45608 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival enabled auto-merge March 15, 2023 13:23
@reviewpad reviewpad bot mentioned this pull request Mar 15, 2023
@vikiival vikiival disabled auto-merge March 15, 2023 14:14
@vikiival
Copy link
Member

pay 25 usd

@vikiival vikiival merged commit d60ad4c into main Mar 15, 2023
@vikiival vikiival deleted the feat-activity-tab branch March 15, 2023 14:14
@yangwao
Copy link
Member

yangwao commented Mar 15, 2023

😍 Perfect, I’ve sent the payout
💵 $25 @ 35.44 USD/KSM ~ 0.705 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xa86e1cab2a14ff1fed6612c4a0e0d059faec44cc8b3287c5a35a15f95e9db82f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity tab improvements
7 participants