Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5216 neo icon #5237

Merged
merged 2 commits into from
Mar 13, 2023
Merged

#5216 neo icon #5237

merged 2 commits into from
Mar 13, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 12, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner March 12, 2023 01:19
@prachi00 prachi00 requested review from preschian and daiagi and removed request for a team March 12, 2023 01:19
@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4512908
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640e43bef552fe00087db587
😎 Deploy Preview https://deploy-preview-5237--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 12, 2023

SUCCESS @prachi00 PR for issue #5216 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@prachi00
Copy link
Member Author

for some reason, size prop isnt working for font-awesome, classes fa-sm and stuff isnt getting applied, should we do it manualy?
@roiLeo

@prachi00 prachi00 requested a review from roiLeo March 12, 2023 01:19
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤗

Please @exezbcz can u check?

@exezbcz
Copy link
Member

exezbcz commented Mar 12, 2023

@vikiival should I go through the whole app or look only into sidebar? Overall there are few icons outstanding

@vikiival
Copy link
Member

@prachi00 can you please provide screenshot with visual changes?

@codeclimate
Copy link

codeclimate bot commented Mar 12, 2023

Code Climate has analyzed commit 4512908 and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

Screen Shot 2023-03-12 at 2 27 42 PM

@exezbcz for now, have changed the icons in the connect wallet part

@prachi00 prachi00 mentioned this pull request Mar 12, 2023
17 tasks
@roiLeo
Copy link
Contributor

roiLeo commented Mar 13, 2023

for some reason, size prop isnt working for font-awesome, classes fa-sm and stuff isnt getting applied, should we do it manualy? @roiLeo

Screenshot 2023-03-13 at 11-15-41 KodaDot - NFT Market Explorer

wfm

@vikiival
Copy link
Member

pay 50 usd

@vikiival vikiival merged commit 443f109 into main Mar 13, 2023
@vikiival vikiival deleted the feat-neo-icon branch March 13, 2023 13:37
@prachi00
Copy link
Member Author

@vikiival seems like the transaction failed for this one and all the recently merged prs as well

@vikiival
Copy link
Member

@yangwao

@vikiival
Copy link
Member

pay 50 usd

@prachi00
Copy link
Member Author

@vikiival still did not happen it seems

@vikiival
Copy link
Member

pay 50 usd

@roiLeo
Copy link
Contributor

roiLeo commented Mar 16, 2023

@vikiival still did not happen it seems

@prachi00 you forgot to put Payout address

@vikiival
Copy link
Member

zkPayout

@prachi00
Copy link
Member Author

oh I did, oops my bad, its EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU added as well
@vikiival @roiLeo

@vikiival
Copy link
Member

Please edit a description for correct payout ^-^. otherwise bot cannot parse it

@prachi00
Copy link
Member Author

Please edit a description for correct payout ^-^. otherwise bot cannot parse it

yeah I did that too yesterday :) thanks

@vikiival
Copy link
Member

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Mar 17, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.38 USD/KSM ~ 1.413 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x3b76eb0509b8539e644dd47c06b97e7e0ee1a75a53cbb884796217c04e1dc863

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoIcon component
7 participants