Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5143 spacing issue explore #5238

Merged
merged 5 commits into from
Mar 14, 2023
Merged

#5143 spacing issue explore #5238

merged 5 commits into from
Mar 14, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 12, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-03-12 at 3 09 24 PM

@prachi00 prachi00 requested a review from a team as a code owner March 12, 2023 22:10
@prachi00 prachi00 requested review from vikiival and daiagi and removed request for a team March 12, 2023 22:10
@kodabot
Copy link
Collaborator

kodabot commented Mar 12, 2023

WARNING @prachi00 PR for issue #5143 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5143

@netlify
Copy link

netlify bot commented Mar 12, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fbff05c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/641053cf44179a0008f4e218
😎 Deploy Preview https://deploy-preview-5238--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00 prachi00 changed the title #5143 #5143 spacing issue explore Mar 12, 2023
@exezbcz
Copy link
Member

exezbcz commented Mar 13, 2023

image

this to 40px please

vikiival
vikiival requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @exezbcz & I said Pls

@vikiival
Copy link
Member

  • please resolve conflicts

@prachi00 prachi00 requested a review from vikiival March 14, 2023 02:34
@vikiival vikiival enabled auto-merge March 14, 2023 10:51
@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023

Code Climate has analyzed commit fbff05c and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit c51009e into main Mar 14, 2023
@vikiival vikiival deleted the feat-spacing-issue branch March 14, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore feedback leftovers
5 participants
@prachi00 @kodabot @exezbcz @vikiival @daiagi