Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preferences store actions #5253

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Mar 13, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix mistyped preferences store actions

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@daiagi daiagi requested a review from a team as a code owner March 13, 2023 15:08
@daiagi daiagi requested review from preschian and vikiival and removed request for a team March 13, 2023 15:08
@daiagi daiagi enabled auto-merge March 13, 2023 15:08
@codeclimate
Copy link

codeclimate bot commented Mar 13, 2023

Code Climate has analyzed commit 49be989 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 49be989
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640f3c99cba82000089eb0e8
😎 Deploy Preview https://deploy-preview-5253--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi daiagi mentioned this pull request Mar 13, 2023
17 tasks
@daiagi daiagi requested a review from roiLeo March 13, 2023 15:10
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 yep sometimes it passes through reviews

✅ code lgtm

@daiagi daiagi merged commit ffd44de into kodadot:main Mar 13, 2023
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Mar 13, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 33.45 USD/KSM ~ 0.598 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x2d0dc8541e8f7edc9ed1140f090d963cd0d82ca198fd6d915e2f7044e523297f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants