Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set prefix parameter to /rmrk/mint router #5254

Closed
wants to merge 2 commits into from

Conversation

zj9495
Copy link

@zj9495 zj9495 commented Mar 13, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@zj9495 zj9495 requested a review from a team as a code owner March 13, 2023 15:29
@zj9495 zj9495 requested review from vikiival and daiagi and removed request for a team March 13, 2023 15:29
@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fcf2af1
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640fdb866294d000087404a6
😎 Deploy Preview https://deploy-preview-5254--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 13, 2023

SUCCESS @zj9495 PR for issue #5247 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RMRK should indeed have text "KSM"

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is correct imo there is something wrong imo in simple mint or so

@zj9495
Copy link
Author

zj9495 commented Mar 14, 2023

The test is correct imo there is something wrong imo in simple mint or so

https://github.com/kodadot/nft-gallery/pull/4869/files#diff-54c1adb4f9778fc990b6a8b75f23df009e785c09226ab6659af40d4346368b77L1
I found that we are using router.params instead of regular expressions to obtain the urlPrefix, so /rmrk/mint cannot obtain the correct urlPrefix, so I think I should configure the prefix parameter for the /rmrk/mint route, is this correct?
I will try it later

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023

Code Climate has analyzed commit fcf2af1 and detected 0 issues on this pull request.

View more on Code Climate.

@zj9495 zj9495 changed the title test: adjust the default unit of the fee fix: set prefix parameter to /rmrk/mint router Mar 14, 2023
@zj9495 zj9495 requested review from roiLeo and vikiival and removed request for daiagi, roiLeo and vikiival March 14, 2023 03:42
@vikiival
Copy link
Member

for the /rmrk/mint route, is this correct? I will try it later

Yup! exactly nice one.

@zj9495 I will close this issue since we try to avoid force pushes into codebase (chceck CONTRIBUTING.MD)

Screenshot 2023-03-14 at 11 43 08

Please create a new PR and I am happy to merge ❤️

@vikiival vikiival closed this Mar 14, 2023
@zj9495
Copy link
Author

zj9495 commented Mar 14, 2023

for the /rmrk/mint route, is this correct? I will try it later

Yup! exactly nice one.

@zj9495 I will close this issue since we try to avoid force pushes into codebase (chceck CONTRIBUTING.MD)

Screenshot 2023-03-14 at 11 43 08

Please create a new PR and I am happy to merge ❤️

make sense, i raised a new PR, plz review again
#5267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests failing over and over
4 participants