Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove grid option from collections #5261

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix: Remove grid option from collections #5261

merged 1 commit into from
Mar 14, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Mar 14, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 14, 2023 02:00
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team March 14, 2023 02:00
@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit e692c4f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/640fd5511a9e0f000893da95
😎 Deploy Preview https://deploy-preview-5261--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Mar 14, 2023

SUCCESS @Jarsen136 PR for issue #5259 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023

Code Climate has analyzed commit e692c4f and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from exezbcz March 14, 2023 02:03
daiagi
daiagi approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 14, 2023
vikiival
vikiival approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one ! ^-^

@vikiival vikiival merged commit 50862ed into kodadot:main Mar 14, 2023
@vikiival
Copy link
Member

pay 15 usd

@yangwao
Copy link
Member

yangwao commented Mar 14, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 33.99 USD/KSM ~ 0.441 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xec8c57f0ab1e92eedb624245ca32314b99105ad0bfc82f028fad31f42b536df1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@exezbcz exezbcz Awaiting requested review from exezbcz

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove grid option from collections
6 participants
@Jarsen136 @kodabot @vikiival @yangwao @daiagi @exezbcz