-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): different landing page visual #5273
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@exezbcz just updat bg imgs, pls check it again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we keep svg
and try to use css filter instead?
@roiLeo yeah, I was thinking the same but cannot find the issue - so basically use the raw shapes and then apply layer blur? for example the right shape is this
its in the figma landing page handoff |
@floyd-li yup, looks good now! |
I think we already mention this in older issue. IMO we need to rework exported svg from figma. |
@exezbcz @roiLeo I tried this before and seems not working well. |
@floyd-li hmm, weird, so the blur filter rendering is based on browser as well
|
not sure but i think |
as i tested, if the css edit: it's a bug reported 4 years ago and seems not been resolved, here's the bugzillia link: id=1530810 |
@floyd-li so i think we can go with the png approach then Thanks for trying tho! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. not really convinced with this solution but let it roll 🎢
Next we might need to resize (& minimify) the png for better aspec ratio
(and use b-image
or nuxt-image
lazy loading)
yep i'll follow up this and try to find a better solution |
Code Climate has analyzed commit ce7ae1b and detected 0 issues on this pull request. View more on Code Climate. |
@vikiival yes, its oki mr. painter :D |
pay 20 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
i found this issue, it's caused by the svg filter
feGaussianBlur
. it has different behavior in different browsers, here's the chrome/firefox/safari's screenshot and you can easily find the difference.also provide a codepen for this, you can use different browser to check behavior: https://codepen.io/floyd-li/pen/abaYXGg
so the solution is, replace these
svg
imgs withpng
.👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸