Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile footer content #5281

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix: Mobile footer content #5281

merged 2 commits into from
Mar 16, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 15, 2023 16:04
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team March 15, 2023 16:04
@kodabot
Copy link
Collaborator

kodabot commented Mar 15, 2023

SUCCESS @Jarsen136 PR for issue #5274 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0938a7c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64127a1f804e4600080f9914
😎 Deploy Preview https://deploy-preview-5281--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Mar 15, 2023

image
bit of collapsing content from 1120px till 770px

otherwise oki,
thank you!

@codeclimate
Copy link

codeclimate bot commented Mar 16, 2023

Code Climate has analyzed commit 0938a7c and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

bit of collapsing content from 1120px till 770px

✅ Fixed
image

@roiLeo roiLeo enabled auto-merge March 16, 2023 09:35
@vikiival
Copy link
Member

Please check the failing workflow

@vikiival
Copy link
Member

image

Cc @exezbcz wdyt

@roiLeo
Copy link
Contributor

roiLeo commented Mar 16, 2023

image

😄
936

@Jarsen136
Copy link
Contributor Author

Please check the failing workflow

Let me re-run the workflow

@roiLeo roiLeo merged commit 7ec66bd into kodadot:main Mar 16, 2023
@vikiival
Copy link
Member

😄 936

Thank you for cute image ❤️ :3
I was playing with 🍏 ✏️ 😅

But What I wanted to say wouln't it be better to have it on two rows?

@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 16, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 33.5 USD/KSM ~ 0.299 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xb23a6f48430f129fe9e04e2fc32fc9cc87c3d46217aed2a0b714728c87b5b227

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 16, 2023
@exezbcz
Copy link
Member

exezbcz commented Mar 16, 2023

@vikiival letsgo,
yup, possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile footer content
7 participants