Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collection display on landing card #5287

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

floyd-li
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

image

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@floyd-li floyd-li requested a review from a team as a code owner March 16, 2023 18:22
@floyd-li floyd-li requested review from preschian and vikiival and removed request for a team March 16, 2023 18:22
@kodabot
Copy link
Collaborator

kodabot commented Mar 16, 2023

SUCCESS @floyd-li PR for issue #5285 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9d35052
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64143d31500e150008016424
😎 Deploy Preview https://deploy-preview-5287--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Mar 16, 2023

can you please also match the hover state on collection/name as on explore

otherwise looks good, thanks!

@floyd-li
Copy link
Member Author

can you please also match the hover state on collection/name as on explore

otherwise looks good, thanks!

updated @exezbcz

@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 17, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 34.86 USD/KSM ~ 0.287 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x1f5f96a6820ce16ec4c08e57c9fa25b4e218827666abf8435890190acea07a79

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@vikiival vikiival enabled auto-merge March 17, 2023 10:12
@yangwao yangwao added the paid pull-request has been paid label Mar 17, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 17, 2023

Code Climate has analyzed commit 9d35052 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival disabled auto-merge March 17, 2023 10:15
@vikiival vikiival enabled auto-merge March 17, 2023 10:15
@vikiival vikiival disabled auto-merge March 17, 2023 10:16
@vikiival vikiival merged commit 19f8df3 into kodadot:main Mar 17, 2023
@floyd-li floyd-li deleted the fix-collection-on-landing branch April 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No collection on NFT cards on landing
5 participants