Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gallery item break point set to 930px #5309

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

floyd-li
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

change the breakpoint for mobile up to 930px

image

@floyd-li floyd-li requested a review from a team as a code owner March 20, 2023 17:43
@floyd-li floyd-li requested review from preschian and Jarsen136 and removed request for a team March 20, 2023 17:43
@kodabot
Copy link
Collaborator

kodabot commented Mar 20, 2023

SUCCESS @floyd-li PR for issue #4762 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 3d11219
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64189b778b1c29000890d7b8
😎 Deploy Preview https://deploy-preview-5309--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit 3d11219 and detected 0 issues on this pull request.

View more on Code Climate.

@floyd-li
Copy link
Member Author

@exezbcz please review this, thanks :)

@exezbcz
Copy link
Member

exezbcz commented Mar 20, 2023

all good, thanks!

@vikiival
Copy link
Member

pay 15 usd

@vikiival vikiival merged commit b17bebe into kodadot:main Mar 20, 2023
@yangwao
Copy link
Member

yangwao commented Mar 20, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 34.54 USD/KSM ~ 0.434 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x99efcfe8d23b048866c3dff63c5776dd54f4518d21f929a27755c32b109d7ad7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 20, 2023
@floyd-li floyd-li deleted the fix-issue-4762 branch March 21, 2023 17:52
@floyd-li floyd-li mentioned this pull request Mar 22, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break point for gallery item
5 participants