Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused boxclass of Error.vue #5315

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Mar 21, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

CleanShot 2023-03-21 at 21 28 17@2x
CleanShot 2023-03-21 at 21 32 56@2x

@kodabot
Copy link
Collaborator

kodabot commented Mar 21, 2023

SUCCESS @leo-anderson-x PR for issue #5184 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c8504d6
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6419aac2d4272f0008621f20
😎 Deploy Preview https://deploy-preview-5315--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@leo-anderson-x leo-anderson-x marked this pull request as ready for review March 21, 2023 12:36
@leo-anderson-x leo-anderson-x requested a review from a team as a code owner March 21, 2023 12:36
@leo-anderson-x leo-anderson-x requested review from preschian and roiLeo and removed request for a team March 21, 2023 12:36
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's the fix I was looking for

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 21, 2023
@vikiival vikiival enabled auto-merge March 21, 2023 13:01
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 21, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 34.77 USD/KSM ~ 0.288 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0x2451c61d7e61078098d5a1156b9e5dc9d865a9fc592cb3e940f9c86a570f6ef8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 21, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2023

Code Climate has analyzed commit c8504d6 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival disabled auto-merge March 21, 2023 14:13
@vikiival vikiival merged commit 9ebb8c9 into kodadot:main Mar 21, 2023
@leo-anderson-x leo-anderson-x deleted the offline-detect-bg branch March 22, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline detected
5 participants