Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: activity tab did not refresh after buy #5327

Merged
merged 14 commits into from
Mar 28, 2023
Merged

fix: activity tab did not refresh after buy #5327

merged 14 commits into from
Mar 28, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Mar 23, 2023 •
edited

Changes

  • Apollo defaults to using cache first strategy, which prevents getting the latest data even after refreshing after a purchase. Here, network first strategy is used during refresh to ensure getting the latest data.
  • use graphql subscription to refresh events data

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
CleanShot.2023-03-25.at.12.05.20.mp4

@kodabot
Copy link
Collaborator

kodabot commented Mar 23, 2023

SUCCESS @leo-anderson-x PR for issue #5318 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c780f98
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/641e5f193f9fea00074540ae
😎 Deploy Preview https://deploy-preview-5327--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@leo-anderson-x leo-anderson-x changed the title expose activity data refresh method fix: activity tab did not refreshed after buy Mar 23, 2023
@leo-anderson-x leo-anderson-x changed the title fix: activity tab did not refreshed after buy WIP fix: activity tab did not refreshed after buy Mar 23, 2023
@leo-anderson-x leo-anderson-x marked this pull request as ready for review March 23, 2023 13:29
@leo-anderson-x leo-anderson-x requested a review from a team as a code owner March 23, 2023 13:29
@leo-anderson-x leo-anderson-x requested review from roiLeo and Jarsen136 and removed request for a team March 23, 2023 13:29
@leo-anderson-x leo-anderson-x changed the title WIP fix: activity tab did not refreshed after buy fix: activity tab did not refreshed after buy Mar 23, 2023
@leo-anderson-x leo-anderson-x changed the title fix: activity tab did not refreshed after buy fix: activity tab did not refresh after buy Mar 23, 2023
roiLeo
roiLeo reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on /snek/gallery/807893860-6 and it didn't work right away, I had to click on Activity tab multiple times.

video

Enregistrement.de.l.ecran.2023-03-23.a.2.40.02.PM.mov

Jarsen136
Jarsen136 requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use graphql subscription to listen the changes on chain, so that all the changes like LIST BUY SEND would be known. So, pls figure out why it does not work as expected.

Pls check the useSubscriptionGraphql method at components/gallery/useGalleryItem.ts line63

components/gallery/GalleryItem.vue Outdated Show resolved Hide resolved
@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 23, 2023
leo-anderson-x and others added 3 commits March 25, 2023 11:30
@codeclimate
Copy link

codeclimate bot commented Mar 25, 2023

Code Climate has analyzed commit c780f98 and detected 0 issues on this pull request.

View more on Code Climate.

@leo-anderson-x leo-anderson-x requested review from roiLeo and Jarsen136 and removed request for roiLeo and Jarsen136 March 25, 2023 03:10
@leo-anderson-x
Copy link
Contributor Author

@roiLeo fixed, I uploaded the demo video to the PR description.

Jarsen136
Jarsen136 approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Mar 25, 2023
@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 27, 2023
vikiival
vikiival approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise oki 🤗

@vikiival
Copy link
Member

pay 20 usd

@vikiival
Copy link
Member

Thanks for the contribution!

@yangwao
Copy link
Member

yangwao commented Mar 28, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 32.68 USD/KSM ~ 0.612 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0x57dc1d487f95711a3f65e806f4fae83fb7fc3036b07d988c910190a6c1b5762b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 28, 2023
@vikiival vikiival merged commit 28336ab into kodadot:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After buy activity tab did not refreshed
6 participants
@leo-anderson-x @kodabot @vikiival @yangwao @roiLeo @Jarsen136