chore: add locale sort/check script #5339

floyd-li · 2023-03-23T12:50:21Z

Thank you for your contribution to the KodaDot NFT gallery.

anyone has idea on how to integrate to CI? 🤔️

what this script do:

sort the locale json keys by alphabet
check other locales missing keys compared with base locale (I set en as default)

👇 _ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes node script to organize locales files #4868
Requires deployment <>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </bsx/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

kodabot · 2023-03-23T12:50:26Z

WARNING @floyd-li PR for issue #4868 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4868

netlify · 2023-03-23T12:50:29Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`7e6d289`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/641d49f9a298080008d13c5d
😎 Deploy Preview	https://deploy-preview-5339--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136

Pls also commit the changes on locales/** after execute the script.

Jarsen136 · 2023-03-23T13:07:39Z

script/checkLocale.mjs

+    table.push([key, checkResult[key]])
+  })
+  console.table(table)
+  throw new Error('Missing Translations')


I'm not sure if we need to throw an error when executing this script. We do know that some translation keys are missing in some language files.

throw which key in which file by local, please :)

hmmm, I plan to add this script to the commit hook, but seems now we are missing plenty of keys with other locales

@roiLeo actually it will display the message in console like this

Compared to eslint command we can't see the the full list here, so I'll have to run it again and again to check & fix missing keys

hmmm yes cuz we are missing a lot of translations now...
maybe we can generate a log.json file to log all the missing locales and keys?

yes! or add a parameter to check specific file

roiLeo

Wow!
This look pretty cool

maybe we can improve table columns with more details

Integrate to CI can come later, nice work ;)

script/checkLocale.mjs

package.json

floyd-li · 2023-03-23T15:23:35Z

just update, and it now supported parameter
usage: pnpm locales:check --locales=en,fr,de,es --baseLocale=en, while the default locale=all and baseLocale=en
and when i tried to check all locales, it get an error while parse JSON of sk.json. seems this locale got specific character? anyone got idea?

roiLeo · 2023-03-23T16:47:11Z

just update, and it now supported parameter usage: pnpm locales:check --locales=en,fr,de,es --baseLocale=en, while the default locale=all and baseLocale=en and when i tried to check all locales, it get an error while parse JSON of sk.json. seems this locale got specific character? anyone got idea?

Maybe bad file format (UTF-8 BOM), should be utf-8

codeclimate · 2023-03-24T06:58:26Z

Code Climate has analyzed commit 7e6d289 and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo

I don't know why but when I run the command it changes all locales files could you take a look?

floyd-li · 2023-03-24T08:48:24Z

I don't know why but when I run the command it changes all locales files could you take a look?

@roiLeo it's expected. this script will check and sort the translation keys

await resortJson()

const checkResult = await checkLocale()

roiLeo

❤️ top! nice work

✅ wfm

vikiival · 2023-03-24T12:58:55Z

woah

vikiival · 2023-03-24T12:59:03Z

pay 30 usd

yangwao · 2023-03-24T12:59:16Z

😍 Perfect, I’ve sent the payout
💵 $30 @ 33.85 USD/KSM ~ 0.886 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0xd875a0fb92796ce7e196a884ce43c13411d514cd3069a691c092a64a2767262b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

chore: add locale check script

c10f9b6

floyd-li requested a review from a team as a code owner March 23, 2023 12:50

floyd-li requested review from roiLeo and Jarsen136 and removed request for a team March 23, 2023 12:50

Jarsen136 reviewed Mar 23, 2023

View reviewed changes

roiLeo reviewed Mar 23, 2023

View reviewed changes

script/checkLocale.mjs Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

floyd-li added 2 commits March 23, 2023 21:34

refactor: rename script

935c37d

refactor: support args

ae7690f

Merge branch 'main' into local-check-script

6e434b9

refactor: set encoding to utf-8

7e6d289

floyd-li requested review from roiLeo and Jarsen136 and removed request for roiLeo and Jarsen136 March 24, 2023 07:00

roiLeo reviewed Mar 24, 2023

View reviewed changes

roiLeo approved these changes Mar 24, 2023

View reviewed changes

roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 24, 2023

floyd-li requested a review from Jarsen136 March 24, 2023 09:12

vikiival merged commit 16a3775 into kodadot:main Mar 24, 2023

yangwao added the paid pull-request has been paid label Mar 24, 2023

roiLeo mentioned this pull request Mar 24, 2023

Way to sync other translations files with en.json #3935

Closed

floyd-li deleted the local-check-script branch October 8, 2023 03:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add locale sort/check script #5339

chore: add locale sort/check script #5339

floyd-li commented Mar 23, 2023

kodabot commented Mar 23, 2023

netlify bot commented Mar 23, 2023 •

edited

Jarsen136 left a comment

Jarsen136 Mar 23, 2023

roiLeo Mar 23, 2023

floyd-li Mar 23, 2023

floyd-li Mar 23, 2023

roiLeo Mar 23, 2023

floyd-li Mar 23, 2023

roiLeo Mar 23, 2023

roiLeo left a comment •

edited

floyd-li commented Mar 23, 2023

roiLeo commented Mar 23, 2023

codeclimate bot commented Mar 24, 2023

roiLeo left a comment

floyd-li commented Mar 24, 2023

roiLeo left a comment •

edited

vikiival commented Mar 24, 2023

vikiival commented Mar 24, 2023

yangwao commented Mar 24, 2023

chore: add locale sort/check script #5339

chore: add locale sort/check script #5339

Conversation

floyd-li commented Mar 23, 2023

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

kodabot commented Mar 23, 2023

netlify bot commented Mar 23, 2023 • edited

✅ Deploy Preview for koda-nuxt ready!

Jarsen136 left a comment

Choose a reason for hiding this comment

Jarsen136 Mar 23, 2023

Choose a reason for hiding this comment

roiLeo Mar 23, 2023

Choose a reason for hiding this comment

floyd-li Mar 23, 2023

Choose a reason for hiding this comment

floyd-li Mar 23, 2023

Choose a reason for hiding this comment

roiLeo Mar 23, 2023

Choose a reason for hiding this comment

floyd-li Mar 23, 2023

Choose a reason for hiding this comment

roiLeo Mar 23, 2023

Choose a reason for hiding this comment

roiLeo left a comment • edited

Choose a reason for hiding this comment

floyd-li commented Mar 23, 2023

roiLeo commented Mar 23, 2023

codeclimate bot commented Mar 24, 2023

roiLeo left a comment

Choose a reason for hiding this comment

floyd-li commented Mar 24, 2023

roiLeo left a comment • edited

Choose a reason for hiding this comment

vikiival commented Mar 24, 2023

vikiival commented Mar 24, 2023

yangwao commented Mar 24, 2023

netlify bot commented Mar 23, 2023 •

edited

roiLeo left a comment •

edited

roiLeo left a comment •

edited