-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust landing page for rmrk2 #5352
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lowering the limit on each chain https://github.com/kodadot/nft-gallery/pull/5352/files#diff-6c61f160d21a8cf4f67e516b372413f9a531149d853f4e430b73c58f48975ef1L31, total still 30. so we can see the latest item from rmrk2 on the last page seems like we can close this #5196. another issue is date on rmrk2 seems not correct related to this #5325 |
seems like |
@vikiival and how will kusama be named (rmrk1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It show only BSX & Snek Rococo items on LatestList & LastestSales for me
is it excepted behavior? maybe indexer issue
currently, we fetch 30 items for each chain. merge them, and then sort them all by date. so, there is a possibility only bsx and snek showing up what if we fetch only 8 items for each chain? so we can see all the latest nft from each chain in that carousel? |
works I guess for now I've made now list of this NFT so should be visible, but probably indexer is still stuck? @vikiival https://beta.kodadot.xyz/rmrk2/gallery/15174172-dac5c7f54029d0e73c-6AFVH-DAWN-00001250 |
indexer should be close to indexed state so maybe we can start seeing something?
|
updated the limit. so we can see rmrk2 even indexer stuck btw, I also hide snek and rmrk2 for production on latest/newest carousel. is that ok? |
posted follow-up issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I also hide snek and rmrk2 for production on latest/newest carousel. is that ok?
it's not a good idea to merge this one if we still have problems fetching rmrk2 images, Users may encounter performance issues (slow loading)
yes
rmrk2 supposed to be on beta only |
let's fix conflicts and I mean it's good to go, we will look and speed up loading of sales |
Code Climate has analyzed commit 5877e73 and detected 0 issues on this pull request. View more on Code Climate. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸