Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust landing page for rmrk2 #5352

Merged
merged 6 commits into from
Mar 30, 2023
Merged

fix: adjust landing page for rmrk2 #5352

merged 6 commits into from
Mar 30, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 24, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-03-24 163122

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 5877e73
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/64251bddb891e40008bba691
😎 Deploy Preview https://deploy-preview-5352--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian
Copy link
Member Author

lowering the limit on each chain https://github.com/kodadot/nft-gallery/pull/5352/files#diff-6c61f160d21a8cf4f67e516b372413f9a531149d853f4e430b73c58f48975ef1L31, total still 30. so we can see the latest item from rmrk2 on the last page

seems like we can close this #5196. another issue is date on rmrk2 seems not correct related to this #5325

@preschian preschian marked this pull request as ready for review March 24, 2023 09:36
@preschian preschian requested a review from a team as a code owner March 24, 2023 09:36
@preschian preschian requested review from roiLeo and vikiival and removed request for a team March 24, 2023 09:36
@preschian
Copy link
Member Author

lowering the limit on each chain #5352 (files), total still 30. so we can see the latest item from rmrk2 on the last page

seems like we can close this #5196. another issue is date on rmrk2 seems not correct related to this #5325

seems like lastEvent query on rmrk2 is not sorted by the latest date. this is the reason we can't see the rmrk2 item if we put the limit of 30 for each chain. because it will be out of order https://github.com/kodadot/nft-gallery/blob/fix/landing-page-rmrk2/components/carousel/utils/useCarousel.ts#L90

Screenshot 2023-03-24 at 19 55 42

@vikiival
Copy link
Member

It's still indexing ^-^

Screenshot 2023-03-24 at 14 06 11

@preschian
Copy link
Member Author

It's still indexing ^-^

Screenshot 2023-03-24 at 14 06 11

aahh, I see. lemme revert the limit back to 30

@exezbcz
Copy link
Member

exezbcz commented Mar 26, 2023

image

  • missing the network indicator in the bottom right corner - rmrk2

@vikiival
Copy link
Member

image

  • missing the network indicator in the bottom right corner - rmrk2

Its kusama

@exezbcz
Copy link
Member

exezbcz commented Mar 26, 2023

@vikiival and how will kusama be named (rmrk1)

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It show only BSX & Snek Rococo items on LatestList & LastestSales for me

is it excepted behavior? maybe indexer issue

@preschian
Copy link
Member Author

It show only BSX & Snek Rococo items on LatestList & LastestSales for me

is it excepted behavior? maybe indexer issue

currently, we fetch 30 items for each chain. merge them, and then sort them all by date. so, there is a possibility only bsx and snek showing up

what if we fetch only 8 items for each chain? so we can see all the latest nft from each chain in that carousel?

@yangwao
Copy link
Member

yangwao commented Mar 27, 2023

what if we fetch only 8 items for each chain? so we can see all the latest nft from each chain in that carousel?

works I guess for now

I've made now list of this NFT so should be visible, but probably indexer is still stuck? @vikiival

https://beta.kodadot.xyz/rmrk2/gallery/15174172-dac5c7f54029d0e73c-6AFVH-DAWN-00001250

@yangwao
Copy link
Member

yangwao commented Mar 28, 2023

what if we fetch only 8 items for each chain? so we can see all the latest nft from each chain in that carousel?

indexer should be close to indexed state so maybe we can start seeing something?

"syncStatus": {
"totalBlocks": 17238206,
"currentBlock": 16376765

@preschian
Copy link
Member Author

preschian commented Mar 29, 2023

what if we fetch only 8 items for each chain? so we can see all the latest nft from each chain in that carousel?

indexer should be close to indexed state so maybe we can start seeing something?

updated the limit. so we can see rmrk2 even indexer stuck

btw, I also hide snek and rmrk2 for production on latest/newest carousel. is that ok?

@preschian
Copy link
Member Author

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I also hide snek and rmrk2 for production on latest/newest carousel. is that ok?

it's not a good idea to merge this one if we still have problems fetching rmrk2 images, Users may encounter performance issues (slow loading)

@yangwao
Copy link
Member

yangwao commented Mar 29, 2023

is that ok?

yes

it's not a good idea to merge this one if we still have problems fetching rmrk2 images

rmrk2 supposed to be on beta only

@yangwao
Copy link
Member

yangwao commented Mar 29, 2023

yes works for me now

image

@yangwao
Copy link
Member

yangwao commented Mar 29, 2023

let's fix conflicts and I mean it's good to go, we will look and speed up loading of sales

@yangwao yangwao self-requested a review March 29, 2023 14:59
@vikiival
Copy link
Member

Screenshot 2023-03-29 at 17 18 02

@codeclimate
Copy link

codeclimate bot commented Mar 30, 2023

Code Climate has analyzed commit 5877e73 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Mar 30, 2023

pay 30 usd

let's say it's there

image

@yangwao yangwao merged commit 5259419 into main Mar 30, 2023
@yangwao yangwao deleted the fix/landing-page-rmrk2 branch March 30, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing RMRK2 latest lists on landing
5 participants