Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear localStorage and sessionStorage #5356

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: clear localStorage and sessionStorage #5356

merged 1 commit into from
Mar 24, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 24, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen.Recording.2023-03-24.at.20.55.56.mov

@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 588c0ef
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/641dad202fbb2e0008988145
😎 Deploy Preview https://deploy-preview-5356--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit 588c0ef and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review March 24, 2023 14:12
@preschian preschian requested a review from a team as a code owner March 24, 2023 14:12
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team March 24, 2023 14:12
roiLeo
roiLeo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. if it helps why not.
maybe pwa setup? I haven't seen the "New version" notification for a while.

Jarsen136
Jarsen136 reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an easier solution to solve the cache issue.

utils/cachingStrategy.ts Show resolved Hide resolved
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 24, 2023
@vikiival vikiival merged commit e526c24 into main Mar 24, 2023
@vikiival vikiival deleted the fix/clear-local-n-session branch March 24, 2023 15:56
@vikiival
Copy link
Member

pay 15 usd

@yangwao
Copy link
Member

yangwao commented Mar 24, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 33.83 USD/KSM ~ 0.443 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x15d1a7c482df78fd3b5bcf9df7766f42cad7c7fbd7e79eee28994a3b3a6e91c6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 24, 2023
@yangwao yangwao mentioned this pull request Mar 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace vuex-settings to static in code
5 participants
@preschian @vikiival @yangwao @roiLeo @Jarsen136