Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add theme text color for <strong> #5357

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

floyd-li
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@floyd-li floyd-li requested a review from a team as a code owner March 24, 2023 14:07
@floyd-li floyd-li requested review from preschian and Jarsen136 and removed request for a team March 24, 2023 14:07
@kodabot
Copy link
Collaborator

kodabot commented Mar 24, 2023

SUCCESS @floyd-li PR for issue #5355 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fffc014
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/641dafeadb000a0008b2d675
😎 Deploy Preview https://deploy-preview-5357--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 24, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit fffc014 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 3b70b74 into kodadot:main Mar 24, 2023
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Mar 24, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 33.76 USD/KSM ~ 0.296 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x1a329b143f2e503340e521747f29e5b56b84b98342f22c96c91b049b1e27682f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 24, 2023
@floyd-li floyd-li deleted the fix-5355 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFT Description is not visible in Light mode
6 participants