Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscribe button styling #5386

Merged
merged 5 commits into from
Mar 28, 2023
Merged

fix: subscribe button styling #5386

merged 5 commits into from
Mar 28, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Mar 26, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

It seems that we have already implemented the corresponding style before, but the change in the internal class name of CustomSubstackWidget caused the overwritten style to fail.

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    CleanShot 2023-03-26 at 22 03 14@2x
    CleanShot 2023-03-27 at 22 57 38@2x

@kodabot
Copy link
Collaborator

kodabot commented Mar 26, 2023

SUCCESS @leo-anderson-x PR for issue #5371 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 26, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 50434fd
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6422e5b7fbf09a0008e418e0
😎 Deploy Preview https://deploy-preview-5386--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@leo-anderson-x leo-anderson-x marked this pull request as ready for review March 26, 2023 13:11
@leo-anderson-x leo-anderson-x requested a review from a team as a code owner March 26, 2023 13:11
@leo-anderson-x leo-anderson-x requested review from roiLeo and Jarsen136 and removed request for a team March 26, 2023 13:11
Jarsen136
Jarsen136 requested changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also fix this mobile issue: submit button is missing.

current preview:
image

should be like this:

ref: #5283

image

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 27, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 8beb4ba and detected 0 issues on this pull request.

View more on Code Climate.

@leo-anderson-x
Copy link
Contributor Author

@Jarsen136 fixed.

CleanShot.2023-03-27.at.23.11.53.2.mp4

@leo-anderson-x leo-anderson-x requested review from Jarsen136 and removed request for roiLeo March 27, 2023 14:15
@Jarsen136 Jarsen136 requested a review from roiLeo March 27, 2023 16:09
@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Mar 27, 2023
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 28, 2023
@vikiival
Copy link
Member

pay 15 usd

@vikiival vikiival merged commit 4fb7b3d into kodadot:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscribe button styling
5 participants
@leo-anderson-x @kodabot @vikiival @roiLeo @Jarsen136