Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cache for chain list #5390

Merged
merged 7 commits into from
Mar 28, 2023
Merged

fix: remove cache for chain list #5390

merged 7 commits into from
Mar 28, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 27, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 440fc79
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6421bbc71ac7da0008d10ad9
😎 Deploy Preview https://deploy-preview-5390--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@kodadot1/static@0.0.1-rc.0 None +0 vikiival

@preschian preschian marked this pull request as ready for review March 27, 2023 08:14
@preschian preschian requested a review from a team as a code owner March 27, 2023 08:14
@preschian preschian requested review from roiLeo and vikiival and removed request for a team March 27, 2023 08:14
@preschian
Copy link
Member Author

preschian commented Mar 27, 2023

@yangwao @vikiival let's try with this one maybe? get chain list from static instead of localstorage

in the current version, we store all vuex modules in sessionStorage. in this PR I only store identity modules. identity is used for wallet connect

Screenshot 2023-03-27 at 15 12 09

composables/useChain.ts Outdated Show resolved Hide resolved
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 27, 2023
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils/chain.ts Show resolved Hide resolved
composables/useChain.ts Show resolved Hide resolved
@vikiival
Copy link
Member

Otherwise, Really nice job !

@yangwao
Copy link
Member

yangwao commented Mar 27, 2023

@yangwao @vikiival let's try with this one maybe?

@preschian I need to merged in main to test with instance where I have it cached if it works

@vikiival
Copy link
Member

Or lets merge better done than perfect

@vikiival vikiival enabled auto-merge March 27, 2023 15:52
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 440fc79 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 87fd19f into main Mar 28, 2023
@vikiival vikiival deleted the fix/chain-list branch March 28, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching in KodaDot
4 participants