Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pwa icons not empty #5406

Merged
merged 6 commits into from
Mar 29, 2023
Merged

chore: fix pwa icons not empty #5406

merged 6 commits into from
Mar 29, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 28, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 87fd3f6
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6423b306c386d7000873b1c0
😎 Deploy Preview https://deploy-preview-5406--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo
Copy link
Contributor

roiLeo commented Mar 28, 2023

I know that static folder is changed by public in nuxt3 maybe it's related?

@preschian preschian marked this pull request as ready for review March 29, 2023 03:32
@preschian preschian requested a review from a team as a code owner March 29, 2023 03:32
@preschian preschian requested review from roiLeo and daiagi and removed request for a team March 29, 2023 03:32
@preschian
Copy link
Member Author

preschian commented Mar 29, 2023

I know that static folder is changed by public in nuxt3 maybe it's related?

not quite sure

let's try this. in this PR I disable the generated icon, and set it manually instead
no icons folder under .nuxt/pwa
Screenshot 2023-03-29 at 10 41 23

let's reopen the issue if the problem still appears

@codeclimate
Copy link

codeclimate bot commented Mar 29, 2023

Code Climate has analyzed commit 87fd3f6 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian changed the title chore: test pwa icons chore: fix pwa icons not empty Mar 29, 2023
@daiagi
Copy link
Contributor

daiagi commented Mar 29, 2023

Will it solve the issue in dev too? Or is it just me that have that?

@preschian
Copy link
Member Author

Will it solve the issue in dev too?

should be yes. sometimes I got that also on dev. but, I don't know how to reproduce it, so I can't ensure that

@yangwao
Copy link
Member

yangwao commented Mar 29, 2023

pay 20 usd
it builds! :)

@yangwao yangwao merged commit 3bcba9c into main Mar 29, 2023
@yangwao yangwao deleted the try-to-fix-pwa-icons branch March 29, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build App Failed directory not empty .nuxt/pwa/icons Directory not empty .nuxt\pwa\icons
4 participants