Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4314 height issue #5439

Merged
merged 5 commits into from
Apr 2, 2023
Merged

#4314 height issue #5439

merged 5 commits into from
Apr 2, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 31, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2023-03-30 at 8 32 20 PM

@prachi00 prachi00 requested a review from a team as a code owner March 31, 2023 03:32
@prachi00 prachi00 requested review from roiLeo and vikiival and removed request for a team March 31, 2023 03:32
@kodabot
Copy link
Collaborator

kodabot commented Mar 31, 2023

WARNING @prachi00 PR for issue #4314 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4314

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bdb6977
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6429551a7057a20008873699
😎 Deploy Preview https://deploy-preview-5439--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vikiival
Copy link
Member

Hey @prachi00,
I have this black stripe https://deploy-preview-5439--koda-nuxt.netlify.app/bsx/create

Screenshot 2023-03-31 at 11 56 21

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment above

@prachi00
Copy link
Member Author

prachi00 commented Apr 1, 2023

@vikiival fixed

@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

Looks oki on iPad

@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

image

@vikiival vikiival enabled auto-merge April 2, 2023 10:12
@codeclimate
Copy link

codeclimate bot commented Apr 2, 2023

Code Climate has analyzed commit bdb6977 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

image

@vikiival vikiival disabled auto-merge April 2, 2023 10:16
@vikiival vikiival merged commit c2b0a46 into main Apr 2, 2023
11 of 12 checks passed
@vikiival vikiival deleted the feat-height-issue-2 branch April 2, 2023 10:16
@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Apr 2, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 33.7 USD/KSM ~ 0.297 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x62cf393fcea64a4e6f822f8d958482765b7fc1e8dcb2c5b49b8a0ba5f33b8ab7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 2, 2023
@EthVlad
Copy link

EthVlad commented Apr 3, 2023

Not really sure if its fixed. I can still see the black space under the footer :/
Screenshot 2023-04-03 at 11 58 06

@roiLeo roiLeo mentioned this pull request Apr 3, 2023
1 task
@vikiival
Copy link
Member

vikiival commented Apr 3, 2023

@VladoTheBoi have you checked https://canary.kodadot.xyz/bsx/create/ ?

@EthVlad
Copy link

EthVlad commented Apr 3, 2023

Ohh my bad, I've checked these 2:

I wasnt sure about the new domains. So how exactly to understand the new ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer should be fixed at the bottom
5 participants