Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sorting by price on collection items page #5449

Merged

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Mar 31, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
CleanShot.2023-03-31.at.22.25.53.2.mp4

@leo-anderson-x leo-anderson-x requested a review from a team as a code owner March 31, 2023 13:28
@leo-anderson-x leo-anderson-x requested review from preschian and Jarsen136 and removed request for a team March 31, 2023 13:28
@kodabot
Copy link
Collaborator

kodabot commented Mar 31, 2023

SUCCESS @leo-anderson-x PR for issue #5446 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7d45351
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6429e7bc07a4540008f8538e
😎 Deploy Preview https://deploy-preview-5449--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2023

Code Climate has analyzed commit f297f7e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment would be on the top of would be nice

if someone creates a page that has either items or collection it would create bug.

Otherwise It does the job

@vikiival vikiival merged commit 37903ee into kodadot:main Apr 2, 2023
11 checks passed
@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Apr 2, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 32.55 USD/KSM ~ 0.307 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0xfed7cabde56e48c0757212cb7c42c956444cc7e77f6bb79f9f7eec71a630c99e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 2, 2023
@leo-anderson-x leo-anderson-x deleted the sorting_by_price_on_collection branch April 3, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting by price on collection
6 participants