Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better markdown support #5514

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 4, 2023 14:11
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team April 4, 2023 14:11
@kodabot
Copy link
Collaborator

kodabot commented Apr 4, 2023

WARNING @Jarsen136 PR for issue #5361 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5361

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2e950b7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/642dae9f1bff130008cc8d0b
😎 Deploy Preview https://deploy-preview-5514--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao mentioned this pull request Apr 5, 2023
@vikiival
Copy link
Member

vikiival commented Apr 5, 2023

@Jarsen136 please resolve conflicts 🥺

@Jarsen136 Jarsen136 marked this pull request as draft April 5, 2023 17:20
@Jarsen136 Jarsen136 marked this pull request as ready for review April 5, 2023 17:20
@reviewpad reviewpad bot added the medium Pull request is medium label Apr 5, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 5, 2023

Code Climate has analyzed commit 2e950b7 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 5, 2023

AI-Generated Pull Request Summary: This pull request includes 3 patches for better markdown support in the application:

  1. The first patch replaces vue-markdown with a new custom Markdown component across the application. This new component now handles markdown rendering, highlighting and redirection logic in one place, making the codebase cleaner and more maintainable.

  2. The second patch fixes a type issue in components/shared/Markdown.vue by removing the unnecessary import of HighlightOptions from highlight.js.

  3. The third patch adds an empty line in components/shared/Markdown.vue to trigger a Git update, potentially for CI/CD purposes.

Along with these changes, several code cleanups and deletions have been made in several files.

@Jarsen136
Copy link
Contributor Author

@Jarsen136 please resolve conflicts 🥺

✅ DONE

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Apr 6, 2023
@vikiival vikiival merged commit 5e8fd36 into kodadot:main Apr 6, 2023
17 checks passed
@vikiival
Copy link
Member

vikiival commented Apr 6, 2023

pay 25 usd

@yangwao
Copy link
Member

yangwao commented Apr 6, 2023

😍 Perfect, I’ve sent the payout
💵 $25 @ 33.14 USD/KSM ~ 0.754 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xb67216b97f9efa093910c3518f36004290585e5a0e1716c74d29281028a31c21

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolink in item description
6 participants