Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong currency in collection detail #5519

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 4, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 4, 2023 18:05
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team April 4, 2023 18:05
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5a11828
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/642e8f1ad7b07f000859a9bc
😎 Deploy Preview https://deploy-preview-5519--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Apr 5, 2023
@yangwao yangwao mentioned this pull request Apr 5, 2023
@vikiival
Copy link
Member

vikiival commented Apr 5, 2023

Please resolve conflicts

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 5, 2023

AI-Generated Pull Request Summary: This pull request fixes the wrong currency issue in the collection detail page by replacing instances of the Money component with the CommonTokenMoney component. The change affects four files: EventRowDesktop.vue, EventRowTablet.vue, FlipperTab.vue, and HolderTab.vue. The incorrect import of the Money component has also been removed.

@reviewpad reviewpad bot added the small Pull request is small label Apr 5, 2023
@Jarsen136
Copy link
Contributor Author

Please resolve conflicts

✅ Done

@roiLeo roiLeo enabled auto-merge April 6, 2023 09:21
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 6, 2023

AI-Generated Pull Request Summary: This pull request includes a fix for wrong currency usage in collection detail. It updates 4 files, mainly changing the Money component to CommonTokenMoney where appropriately to ensure the correct currency is displayed. This affects the Event Row component for both Desktop and Tablet views and the Flipper Tab and Holder Tab in owner insights.

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2023

Code Climate has analyzed commit 5a11828 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit e7b6c02 into kodadot:main Apr 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong currency in activity
4 participants