#5435 rmrk label

[prachi00]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Show on landing in latest sales & listing RMRK2 in card  #5435
• Requires deployment <>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </bsx/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

WARNING @prachi00 PR for issue #5435 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5435

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	da1a707
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6431bf13437d9e0008b8316c
😎 Deploy Preview	https://deploy-preview-5561--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[prachi00]

it seems like my changes got reversed somehow, works now @yangwao

[reviewpad]

AI-Generated Summary: This pull request modifies two files (names.ts and types.ts) in the libs/static/src directory. It updates the 'NAMES' record by replacing the 'ksm' prefix with 'rmrk2' and adding a new 'ksm' entry for 'Kusama'. Additionally, the 'Prefix' type in types.ts has been updated to include 'rmrk2'. Overall, this patch addresses the naming of the RMRK label and introduces a new prefix for RMRK 2.0 [Beta].

[Jarsen136]

code lgtm

[yangwao]

@prachi00 doesn't build

https://github.com/kodadot/nft-gallery/actions/runs/4641899175/jobs/8217336465?pr=5561#step:3:317

[prachi00]

@prachi00 doesn't build

https://github.com/kodadot/nft-gallery/actions/runs/4641899175/jobs/8217336465?pr=5561#step:3:317

@yangwao fixed

[codeclimate]

Code Climate has analyzed commit da1a707 and detected 0 issues on this pull request.

View more on Code Climate.

[reviewpad]

AI-Generated Summary: This pull request contains two patches addressing changes in the naming and types for prefixes. The first patch (#5435 rmrk label) updates the 'NAMES' record in 'libs/static/src/names.ts' by changing the key 'ksm' to 'rmrk2' and adding an entry for 'Kusama' with the key 'ksm'. The second patch (fixing build) modifies the import statement in 'libs/static/src/names.ts' to import 'BackwardPrefix' instead of 'Prefix' and adjusts the 'NAMES' record accordingly. Additionally, 'libs/static/src/types.ts' is updated to remove the 'rmrk2' prefix.

[yangwao]

perfect 👍

[yangwao]

pay 10 usd