Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ update sorting options #5642

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Apr 13, 2023

Recently interacted = most interacted in short time horizon no? At Least for us.

Not implemented yet

PR Type

  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

Screenshot 2023-04-13 at 12-02-51 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer
Screenshot 2023-04-13 at 12-03-13 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner April 13, 2023 09:19
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team April 13, 2023 09:19
@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ec74872
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64396fa6fb50470008a8fda8
😎 Deploy Preview https://deploy-preview-5642--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request updates the sorting options by changing some labels, making translations more accurate, removing unused items, and reordering some options. The changes are made in the ExploreSort.vue component, as well as updating the localization files en.json and fr.json, and modifying the sorting condition lists in constants.ts.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request includes two patches that update sorting options in the application. The first patch modifies explore UI, locales and utility constants to better reflect the updated sorting options. The second patch updates collection sorting options in the utility constants file. These changes aim to improve the sorting experience within the application.

@codeclimate
Copy link

codeclimate bot commented Apr 14, 2023

Code Climate has analyzed commit ec74872 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm ✅

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 14, 2023
@yangwao yangwao merged commit 28b62d5 into kodadot:main Apr 14, 2023
16 checks passed
@roiLeo roiLeo deleted the chore/explore/sortOptions branch April 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting by Serial Number Ascending is not working Sorting: explained
3 participants