Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 MediaItem placeholder prop #5644

Merged
merged 3 commits into from
Apr 20, 2023
Merged

🔧 MediaItem placeholder prop #5644

merged 3 commits into from
Apr 20, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Apr 13, 2023 •
edited by ghost

PR Type

  • Bugfix
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

⏳

🤖 Generated by Copilot at 9846b66

Oh we're the coders of the NFTs
And we work hard to make them please
We added a placeholder prop
To show the right image on the top

@roiLeo roiLeo requested a review from a team as a code owner April 13, 2023 10:17
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team April 13, 2023 10:17
@netlify
Copy link

netlify bot commented Apr 13, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9ffcf41
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6440fe1e0a22180008e1b117
😎 Deploy Preview https://deploy-preview-5644--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request makes changes to the MediaItem component, GalleryItem component, and other related components. The main update is the addition of a new placeholder prop that can be used to set custom placeholder images based on the application's theme. This replaces the previous hardcoded placeholder image, resulting in a more flexible and consistent UI. The pull request consists of 33 insertions and 17 deletions across 7 files.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 13, 2023
Jarsen136
Jarsen136 reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm think that if we could put the placeholder image into useTheme composable function. In this way, we could avoid some duplicate logic code.

components/gallery/GalleryItem.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItemPreviewer.vue Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGridImage.vue Outdated Show resolved Hide resolved
components/shared/gallery/NftCard.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit 9ffcf41 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Apr 20, 2023

I'm think that if we could put the placeholder image into useTheme composable function. In this way, we could avoid some duplicate logic code.

Thanks! 🤸‍♂️

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 20, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Apr 20, 2023

🚀

@roiLeo roiLeo merged commit 83ea2f4 into kodadot:main Apr 20, 2023
16 checks passed
@roiLeo roiLeo deleted the fix/MediaItem/placeholder branch April 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ImageMedia more accessible for non-KodaDot projects
3 participants
@roiLeo @daiagi @Jarsen136