Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel landing page beta #5651

Merged
merged 8 commits into from
Apr 14, 2023
Merged

fix: carousel landing page beta #5651

merged 8 commits into from
Apr 14, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Apr 13, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-04-13 at 21 22 38

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f162318
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/643810b60e19940008ec9551
😎 Deploy Preview https://deploy-preview-5651--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request contains two patches:

  1. Fix: show KSM on the landing page
  • Updates the key on the Carousel components to use ids instead of nfts.length
  • Refactors the useCarousel.ts and utils/chain.ts to use the disableChainListOnProductionEnv variable from utils/constants.ts
  • Adds an ids computed property that maps the nft ids in the useCarouselNftEvents function
  1. Feat: add isBeta
  • Adds a separate flag for isBeta to determine if the current environment is the beta version
  • Updates the useChainEvents function to conditionally disable certain chains on the beta environment
  • Makes use of the isBeta flag in relevant places

@reviewpad reviewpad bot added the small Pull request is small label Apr 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request consists of three patches that aim to improve the project by:

  1. Fixing the display of KSM on the landing page. The changes include updating keys for CarouselTypeLatestSales.vue and CarouselTypeNewestList.vue components, and refactoring related codes in useCarousel.ts, chain.ts, and constants.ts.
  2. Adding an isBeta feature to the code, which distinguishes between production and beta versions. The changes affect useCarousel.ts and chain.ts.
  3. Reverting changes to constants.ts related to the isProduction feature.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request consists of 4 patches that mainly fix the display of KSM on the landing page and make tweaks related to the separate handling of production and beta environments. The changes include:

  1. Updating key bindings and using 'ids' in CarouselTypeLatestSales and CarouselTypeNewestList components.
  2. Adding 'isBeta' flag to manage carousel items separately for production and beta environments.
  3. Reverting constants to a previous state.
  4. Separating the beta and production environments logic by updating the hostname values and adding 'disableChainListOnBetaEnv' constant for chain disabling in the beta environment. Several adjustments are made in 'useCarouselVisited' and 'useCarouselRelated' functions in useCarousel.ts as well.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request contains 5 patches that primarily focus on updating carousel components, fixing certain issues, and adding new features. The changes include:

  1. Fixing the display of Kusama (KSM) on the landing page.
  2. Adding an isBeta feature to differentiate between the beta and production environments.
  3. Reverting changes to the constants file.
  4. Separating the beta and production environments with separate settings for disabling chains.
  5. Updating the domain names for production and beta environments in the chain.ts file.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 13, 2023

AI-Generated Summary: This pull request contains 6 patches that focus on fixing the display of KSM on the landing page, adding an isBeta feature, separating beta and production environments, and updating domain-related logic. The changes involve modifying components/carousel-related files, utils/chain.ts, and utils/constants.ts. Additionally, the PR addresses a few minor code improvements and bug fixes.

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit f162318 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review April 13, 2023 14:26
@preschian preschian requested a review from a team as a code owner April 13, 2023 14:26
@preschian preschian requested review from roiLeo and daiagi and removed request for a team April 13, 2023 14:26
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't really test it until goes on beta
yolo

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 13, 2023
@preschian
Copy link
Member Author

can't really test it until goes on beta

in case you wanna test it locally:

  1. put kodadot.xyz and beta.kodadot.xyz in /etc/hosts. pointing to 127.0.0.1
  2. open beta.kodadot.xyz:9090 on incognito with this PR running on local
  3. after testing, we can revert /etc/hosts

@yangwao
Copy link
Member

yangwao commented Apr 14, 2023

pay 20 usd

@yangwao yangwao merged commit 61bd3dd into main Apr 14, 2023
17 checks passed
@yangwao yangwao deleted the fix/ksm-landing-page-beta branch April 14, 2023 11:07
@yangwao
Copy link
Member

yangwao commented Apr 14, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 36.64 USD/KSM ~ 0.546 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xa6b07ee1665ebaae705fb68f718a91630827c7a5d320e0a00118d01777db1630

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird thing happening on beta
3 participants