🔧 windows workflow

[roiLeo]

🧪

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	9a2117f
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64395ed1552dc9000741f541
😎 Deploy Preview	https://deploy-preview-5661--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[reviewpad]

AI-Generated Summary: This pull request consists of two patches. The first patch simplifies the GitHub build workflow and removes unnecessary workflow steps, with modifications in .github/workflows/build.yml and .github/workflows/e2e.yml. It also adds a new story file for the NeoModal component (NeoModal.story.vue). The second patch updates the badges in README.md to reflect the changes made to the workflow. Overall, this PR improves the GitHub Actions workflows and enhances the project's documentation.

[reviewpad]

Reviewpad Report

⚠️ Warnings

• Please link an issue to the pull request

[roiLeo]

hello @yangwao I think you need to unset required build workflow

[yangwao]

wild neomodal component appears in CI PR 👀

[reviewpad]

AI-Generated Summary: This pull request contains 3 patches:

1. The first patch modifies the GitHub workflows build.yml and e2e.yml, simplifying the build job's strategy and removing an unnecessary ls -l command. It also adds a new NeoModal.story.vue file that demonstrates a NeoNftCard component using a NeoModal.

2. The second patch updates the badges in the README.md file to reflect the simplified build workflow.

3. The third patch removes a mistakenly added file, NeoModa.story.vue, fixing a file name typo.

[roiLeo]

wild neomodal component appears in CI PR 👀

yep typo in file fixed 6f94e63

edit:

3. The third patch removes a mistakenly added file, `NeoModa.story.vue`, fixing a file name typo.

[daiagi]

how to test that it works?

[yangwao]

how to test that it works?

there is only one way to find out

[preschian]

how to test that it works?

we can see the result in this PR. need to unset required for ubuntu-latest and windows-latest

[roiLeo]

we can see the result in this PR. need to unset required for ubuntu-latest and windows-latest

is it set on "Settings" tab?

By the way we have errors on histoire build, I'm preparing a fix

[preschian]

is it set on "Settings" tab?

yes, need help from @yangwao 🙏🏻

hello @yangwao I think you need to unset required build workflow

[yangwao]

this?

Screen.Recording.2023-04-14.at.15.45.31.mov

removed both

which checks I should add? I guess we just want to things to build

[roiLeo]

this?

Looks like it's working

[codeclimate]

Code Climate has analyzed commit 9a2117f and detected 0 issues on this pull request.

View more on Code Climate.