Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chains and names #5664

Merged
merged 4 commits into from
Apr 14, 2023
Merged

chains and names #5664

merged 4 commits into from
Apr 14, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 14, 2023

  • πŸ› sanitizing prefix reason
  • ⬆️ @kodadot1/vuex-options
  • 🏷️ RMRK2 forever

Thank you for your contribution to the KodaDot NFT gallery.

πŸ‘‡ _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests πŸ§ͺ
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot πŸ“Έ

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-04-14 at 15 11 56

Screenshot 2023-04-14 at 15 12 01

@vikiival vikiival requested a review from a team as a code owner April 14, 2023 13:12
@vikiival vikiival requested review from daiagi and Jarsen136 and removed request for a team April 14, 2023 13:12
@netlify
Copy link

netlify bot commented Apr 14, 2023

βœ… Deploy Preview for koda-canary ready!

Name Link
πŸ”¨ Latest commit 59bb501
πŸ” Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/643958d022eee900085677cd
😎 Deploy Preview https://deploy-preview-5664--koda-canary.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 14, 2023

AI-Generated Summary: This pull request includes 3 patches:

  1. Sanitizing prefix reason by removing the hardcoded check for 'rmrk' prefix in the getChainNameByPrefix function in utils/chain.ts.
  2. Updating the @kodadot1/vuex-options package to version 0.1.1-rc.0 in both package.json and pnpm-lock.yaml.
  3. Updating the label for ksm prefix in the NAMES object within the libs/static/src/names.ts file from 'RMRK 2.0 [Beta]' to 'RMRK2'.

@exezbcz
Copy link
Member

exezbcz commented Apr 14, 2023

in navbar it still shows kusama sir
image

@yangwao
Copy link
Member

yangwao commented Apr 14, 2023

in navbar it still shows kusama sir

yup, should be showing RMRK2 in navbar @vikiival

@codeclimate
Copy link

codeclimate bot commented Apr 14, 2023

Code Climate has analyzed commit 59bb501 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member Author

Screenshot 2023-04-14 at 15 45 37

@yangwao
Copy link
Member

yangwao commented Apr 14, 2023

sending happy yellow koala

image

@vikiival
Copy link
Member Author

7i5bnl

@yangwao
Copy link
Member

yangwao commented Apr 14, 2023

works

@yangwao yangwao merged commit e1d0b5c into main Apr 14, 2023
17 checks passed
@yangwao yangwao deleted the chains-and-names branch April 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish between RMRKv1 and RMRKv2 ? Missclick? Isn't this suppose to be RMRK2?
3 participants