Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not showing royalties in gallery detail #5674

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix: not showing royalties in gallery detail #5674

merged 2 commits into from
Apr 17, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Apr 15, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Context

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

CleanShot 2023-04-15 at 12 32 34@2x

@leo-anderson-x leo-anderson-x requested a review from a team as a code owner April 15, 2023 03:36
@leo-anderson-x leo-anderson-x requested review from vikiival and daiagi and removed request for a team April 15, 2023 03:36
@kodabot
Copy link
Collaborator

kodabot commented Apr 15, 2023

SUCCESS @leo-anderson-x PR for issue #5671 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 15, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 640d822
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/643d279ba121f400089aca2d
😎 Deploy Preview https://deploy-preview-5674--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 15, 2023

AI-Generated Summary: This pull request includes a fix for not showing royalties in gallery detail. It adds the royalty field to nftById.graphql queries for both ksm and rmrk implementations, ensuring that royalty information is fetched and displayed correctly. The changes affect a total of 2 files, with 2 insertions made.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 15, 2023
roiLeo
roiLeo suggested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no things as royalty on rmrk v1.0.0

@codeclimate
Copy link

codeclimate bot commented Apr 17, 2023

Code Climate has analyzed commit 640d822 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 17, 2023
@vikiival vikiival merged commit b1421c0 into kodadot:main Apr 17, 2023
16 checks passed
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Apr 17, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 36.21 USD/KSM ~ 0.276 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0x58a1960e2d6ef718a8e89e6272563e8347e66394212818518941510cfc56063e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not showing royalties in gallery detail
7 participants
@leo-anderson-x @kodabot @vikiival @yangwao @roiLeo @daiagi @exezbcz