Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5697 Clickable nft in holders/flipper tab #5710

Merged
merged 3 commits into from
Apr 23, 2023
Merged

#5697 Clickable nft in holders/flipper tab #5710

merged 3 commits into from
Apr 23, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Apr 18, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at c5fa806

Added links to NFT gallery pages for flips and holders in owner insights tabs. This improves the user experience and navigation for collection owners. Used a common urlPrefix variable to handle different network and environment settings in Flipper.vue and Holder.vue components.

🤖 Generated by Copilot at c5fa806

urlPrefix helps
link to NFT galleries
autumn of the flip

@prachi00 prachi00 requested a review from a team as a code owner April 18, 2023 05:35
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team April 18, 2023 05:35
@kodabot
Copy link
Collaborator

kodabot commented Apr 18, 2023

SUCCESS @prachi00 PR for issue #5697 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 18, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d73a81f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6442bcf0053f0d0007d410dd
😎 Deploy Preview https://deploy-preview-5710--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 18, 2023

AI-Generated Summary: This pull request includes changes in two Vue.js component files, Flipper.vue and Holder.vue. It adds nuxt-link elements for better navigation, making the displayed items clickable and directing them to respective gallery pages. The urlPrefix is also utilized for generating the correct URLs for navigating to the NFT gallery pages. Additionally, this patch improves code formatting and readability.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 18, 2023
@yangwao yangwao changed the title #5697 #5697 Clickable nft in holders/flipper tab Apr 18, 2023
@yangwao yangwao mentioned this pull request Apr 18, 2023
Merged
@exezbcz
Copy link
Member

exezbcz commented Apr 19, 2023

the whole text now in the flipper tab changes
image

  • you cant copy select from the data because you have pointer cursor

remove hover color from the link please
image

can you seperate the version to holders tab and flippers please? the holders could have the pointer all over the are, but flipper tab only pointer on pfp and name of nft

@exezbcz exezbcz added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 19, 2023
@prachi00
Copy link
Member Author

the whole text now in the flipper tab changes image

  • you cant copy select from the data because you have pointer cursor

remove hover color from the link please image

can you seperate the version to holders tab and flippers please? the holders could have the pointer all over the are, but flipper tab only pointer on pfp and name of nft

done

@exezbcz
Copy link
Member

exezbcz commented Apr 20, 2023

remove hover color from the link please
image

this please as last thing, otherwise oki

can you seperate the version to holders tab and flippers please? the holders could have the pointer all over the are, but flipper tab only pointer on pfp and name of nft

with this in mind

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2023

Code Climate has analyzed commit d73a81f and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

remove hover color from the link please
image

this please as last thing, otherwise oki

can you seperate the version to holders tab and flippers please? the holders could have the pointer all over the are, but flipper tab only pointer on pfp and name of nft

with this in mind

removed from holders - done , flippers hover color is fine right?

@exezbcz exezbcz added S-visual-ok-✅ and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Apr 22, 2023
@yangwao yangwao mentioned this pull request Apr 22, 2023
Merged
@vikiival vikiival merged commit f77da3c into main Apr 23, 2023
16 checks passed
@vikiival vikiival deleted the feat-clickable branch April 23, 2023 13:17
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Apr 23, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 30.42 USD/KSM ~ 0.329 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x9a459ec5097bbd4b7d2693e7199614227dc640f286b46a9dc1cb17a9a05fd1b1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 23, 2023
@yangwao yangwao mentioned this pull request Apr 24, 2023
Closed
This was referenced Apr 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clickable nft in holders/flipper tab
6 participants
@prachi00 @kodabot @exezbcz @vikiival @yangwao @preschian