Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards change #5711

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Cards change #5711

merged 6 commits into from
Apr 18, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Apr 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 5f95f5d

Refactored the styles and components of various cards in the UI and the gallery to use a new card-border-color variable and to remove unnecessary animations. This improves the performance, design consistency, and code maintainability of the project.

🤖 Generated by Copilot at 5f95f5d

CardArticle style
shared across components now
less code, more spring

@daiagi daiagi requested a review from a team as a code owner April 18, 2023 06:07
@daiagi daiagi requested review from roiLeo and vikiival and removed request for a team April 18, 2023 06:07
@kodabot
Copy link
Collaborator

kodabot commented Apr 18, 2023

WARNING @daiagi PR for issue #5687 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5687

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5f95f5d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/643e339fa5b44b0008685023
😎 Deploy Preview https://deploy-preview-5711--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi daiagi requested review from exezbcz and Jarsen136 and removed request for vikiival April 18, 2023 06:07
@codeclimate
Copy link

codeclimate bot commented Apr 18, 2023

Code Climate has analyzed commit 5f95f5d and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 18, 2023

AI-Generated Summary: This pull request includes changes to various SCSS files focusing mainly on card elements. The changes include introducing new theme variables for 'card-border-color' and 'card-hover-opacity', updating the border and hover styles of carousel cards, top collection cards, gallery item cards, gallery collection cards, and article cards to use the new theme variables. These updates enhance the visual appearance and consistency of the cards across different components.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 18, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Apr 18, 2023

Effected cards:

Landing Page

  • All Carousel cards (Spotlight, Newest List, Latest Sales)
  • Top Collections
  • Featured Articles

Explore / Item Grid

  • items tab cards
  • collections tab cards

@exezbcz
Copy link
Member

exezbcz commented Apr 18, 2023

looks good to me!

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like adding opacity on hover, normally I would have seen the opposite.
Duplicate theme variable code :/
This libs/ui is starting to be less sustainable.

otherwise lgtm ✅

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 18, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Apr 18, 2023

Duplicate theme variable code :/
This libs/ui is starting to be less sustainable.

True

@exezbcz
Copy link
Member

exezbcz commented Apr 18, 2023

I don't really like adding opacity on hover, normally I would have seen the opposite.
Duplicate theme variable code :/
This libs/ui is starting to be less sustainable.

otherwise lgtm ✅

What do you mean by seeing the opposite? Would you remove the hover opacity completely? Thanks for feedback!

@roiLeo
Copy link
Contributor

roiLeo commented Apr 18, 2023

What do you mean by seeing the opposite?

Opacity by default, remove opacity on hover. I find it strange to add opacity on something that should stand out.

Would you remove the hover opacity completely? Thanks for feedback!

I would reintroduce a slight zoom on hover effect

@exezbcz
Copy link
Member

exezbcz commented Apr 18, 2023

Opacity by default, remove opacity on hover. I find it strange to add opacity on something that should stand out.

  • the opacity is mainly for future cart button over the img and other functionalities
  • that means it will stands out

I would reintroduce a slight zoom on hover effect

  • yup, that sounds good, I would leave it to another version tho

@yangwao
Copy link
Member

yangwao commented Apr 18, 2023

I don't really like adding opacity on hover, normally I would have seen the opposite.

Inspiration was coming from https://www.tensor.trade/trade/oogy_pods this is way how we implemented it in now in visual way, as current animation when you are hovering with cursor over are quite slow nad missing, also removing that sharp borders was intrusive

I would reintroduce a slight zoom on hover effect

yeah we had this zoom, which I was thinking, it's possible option. I would like to keep it as basic as possible those animation tbh to not disturb user. Other experiments we can try in fandoms shops for example, let's see, there is room accommodate lot of approaches I guess per collection.

@yangwao
Copy link
Member

yangwao commented Apr 18, 2023

pay 60 usd

quick delivery on first try! like it!

@yangwao yangwao merged commit b8d9b40 into main Apr 18, 2023
17 checks passed
@yangwao yangwao deleted the cards-change branch April 18, 2023 11:32
@yangwao
Copy link
Member

yangwao commented Apr 18, 2023

😍 Perfect, I’ve sent the payout
💵 $60 @ 37.46 USD/KSM ~ 1.602 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x6e7450ef76cd641d5490c0bebf65d058409409124e2baa0912f369a56fc5c5a0

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards change
5 participants