-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cards change #5711
Cards change #5711
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Code Climate has analyzed commit 5f95f5d and detected 0 issues on this pull request. View more on Code Climate. |
AI-Generated Summary: This pull request includes changes to various SCSS files focusing mainly on card elements. The changes include introducing new theme variables for 'card-border-color' and 'card-hover-opacity', updating the border and hover styles of carousel cards, top collection cards, gallery item cards, gallery collection cards, and article cards to use the new theme variables. These updates enhance the visual appearance and consistency of the cards across different components. |
Effected cards: Landing Page
Explore / Item Grid
|
looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like adding opacity on hover, normally I would have seen the opposite.
Duplicate theme variable code :/
This libs/ui
is starting to be less sustainable.
otherwise lgtm ✅
True |
What do you mean by seeing the opposite? Would you remove the hover opacity completely? Thanks for feedback! |
Opacity by default, remove opacity on hover. I find it strange to add opacity on something that should stand out.
I would reintroduce a slight zoom on hover effect |
|
Inspiration was coming from https://www.tensor.trade/trade/oogy_pods this is way how we implemented it in now in visual way, as current animation when you are hovering with cursor over are quite slow nad missing, also removing that sharp borders was intrusive
yeah we had this zoom, which I was thinking, it's possible option. I would like to keep it as basic as possible those animation tbh to not disturb user. Other experiments we can try in fandoms shops for example, let's see, there is room accommodate lot of approaches I guess per collection. |
pay 60 usd quick delivery on first try! like it! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 5f95f5d
Refactored the styles and components of various cards in the UI and the gallery to use a new
card-border-color
variable and to remove unnecessary animations. This improves the performance, design consistency, and code maintainability of the project.🤖 Generated by Copilot at 5f95f5d