Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display collection profile in search result #5723

Merged
merged 10 commits into from
Apr 20, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Apr 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

Copilot Summary

🤖 Generated by Copilot at 120792d

Improved the appearance and functionality of the search result components, showing larger and better-styled NFT thumbnails and displaying the floor price and the number of units for collections and series. Modified SearchResultItem.vue and SearchSuggestion.vue files.

🤖 Generated by Copilot at 120792d

NFT thumbnails
bigger, styled, informative
showing floor price - spring

@floyd-li floyd-li requested a review from a team as a code owner April 18, 2023 18:05
@floyd-li floyd-li requested review from daiagi and Jarsen136 and removed request for a team April 18, 2023 18:05
@kodabot
Copy link
Collaborator

kodabot commented Apr 18, 2023

WARNING @floyd-li PR for issue #5500 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5500

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b0118c9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64401218e25cc3000772dd69
😎 Deploy Preview https://deploy-preview-5723--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 18, 2023

AI-Generated Summary: This pull request includes the following changes:

  1. Updates the image size in SearchResultItem.vue by changing the width and height from 48px to 64px.
  2. Adds collection information to the search result in SearchSuggestion.vue. This information includes the activity floor price and the number of units in the collection.
  3. Fixes the image max height issue in SearchResultItem.vue by adding a scoped style to override the max height property of the img element.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 18, 2023
@floyd-li floyd-li changed the title Feat/collection profile in search feat: display collection profile in search result Apr 18, 2023
@daiagi daiagi added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 18, 2023
Co-authored-by: Luke Fishman <daiagi@gmail.com>
@daiagi daiagi removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 18, 2023
@yangwao
Copy link
Member

yangwao commented Apr 18, 2023

Sometimes doesn't work hmm

image

I don't see any related errors

image

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing
otherewise code lgtm ✔️

components/search/SearchSuggestion.vue Outdated Show resolved Hide resolved
@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 19, 2023
components/search/SearchSuggestion.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • floor price should be greater than zero.
  • ksm/bsx unit

image

Co-authored-by: Luke Fishman <daiagi@gmail.com>
@yangwao
Copy link
Member

yangwao commented Apr 19, 2023

Any idea why it doesn't work for me? I don't see any error console nor pending network request in console.

image

@yangwao
Copy link
Member

yangwao commented Apr 19, 2023

@floyd-li it actually returns in network well, yet it doesn't shows?

My thesis is that.. if resources comes later than in some "first batch", we don't swap the new resource, is that possible?

image

@floyd-li
Copy link
Member Author

@floyd-li it actually returns in network well, yet it doesn't shows?

My thesis is that.. if resources comes later than in some "first batch", we don't swap the new resource, is that possible?

working on this

@yangwao
Copy link
Member

yangwao commented Apr 19, 2023

working on this

looks like it's working! 😍

image

@yangwao yangwao added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 19, 2023
@Jarsen136
Copy link
Contributor

Jarsen136 commented Apr 19, 2023

Pls hide floor: 0 KSM where the collection has no item having a price.
image

Here is what opensea does in this case.
image

@floyd-li
Copy link
Member Author

image

is it okay?

@codeclimate
Copy link

codeclimate bot commented Apr 19, 2023

Code Climate has analyzed commit b0118c9 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor

image

is it okay?

Yes, it looks good.

@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

this was quick @floyd-li , love it!

pay 40 usd

let's look maybe on this one

@yangwao yangwao merged commit 9425536 into kodadot:main Apr 20, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

😍 Perfect, I’ve sent the payout
💵 $40 @ 34.26 USD/KSM ~ 1.168 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x1ddbf6b06f6204ae1a2992bca766f4183d73b8e1fdf23815a1b3cbb29fcde35c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 20, 2023
This was referenced Apr 24, 2023
@floyd-li floyd-li deleted the feat/collection-profile-in-search branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection preview doesn't show in searchbar
5 participants